Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chrome/browser/android/bookmarks/bookmark_bridge.cc

Issue 1935413003: [Android Bookmark] Remove all bookmark section from bookmark manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make a histogram obsolete Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/bookmarks/bookmark_bridge.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/bookmarks/bookmark_bridge.cc
diff --git a/chrome/browser/android/bookmarks/bookmark_bridge.cc b/chrome/browser/android/bookmarks/bookmark_bridge.cc
index 47b35637a0291a60e8d0eb8a97a2e8981569ef9b..3b0af2c373b971a8e11b1eeadf46dd53134b4b7e 100644
--- a/chrome/browser/android/bookmarks/bookmark_bridge.cc
+++ b/chrome/browser/android/bookmarks/bookmark_bridge.cc
@@ -52,13 +52,6 @@ using content::BrowserThread;
namespace {
-class BookmarkNodeCreationTimeCompareFunctor {
- public:
- bool operator()(const BookmarkNode* lhs, const BookmarkNode* rhs) {
- return lhs->date_added().ToJavaTime() > rhs->date_added().ToJavaTime();
- }
-};
-
class BookmarkTitleComparer {
public:
explicit BookmarkTitleComparer(BookmarkBridge* bookmark_bridge,
@@ -451,53 +444,6 @@ ScopedJavaLocalRef<jobject> BookmarkBridge::GetChildAt(
env, child->id(), GetBookmarkType(child));
}
-void BookmarkBridge::GetAllBookmarkIDsOrderedByCreationDate(
- JNIEnv* env,
- const JavaParamRef<jobject>& obj,
- const JavaParamRef<jobject>& j_result_obj) {
- DCHECK(IsLoaded());
- std::list<const BookmarkNode*> folders;
- std::vector<const BookmarkNode*> result;
- folders.push_back(bookmark_model_->root_node());
-
- for (std::list<const BookmarkNode*>::iterator folder_iter = folders.begin();
- folder_iter != folders.end(); ++folder_iter) {
- if (*folder_iter == NULL)
- continue;
-
- std::list<const BookmarkNode*>::iterator insert_iter = folder_iter;
- ++insert_iter;
-
- for (int i = 0; i < (*folder_iter)->child_count(); ++i) {
- const BookmarkNode* child = (*folder_iter)->GetChild(i);
- if (!IsReachable(child) ||
- bookmarks::IsDescendantOf(
- child, managed_bookmark_service_->managed_node()) ||
- bookmarks::IsDescendantOf(
- child, managed_bookmark_service_->supervised_node())) {
- continue;
- }
-
- if (child->is_folder()) {
- insert_iter = folders.insert(insert_iter, child);
- } else {
- result.push_back(child);
- }
- }
- }
-
- std::sort(
- result.begin(), result.end(), BookmarkNodeCreationTimeCompareFunctor());
-
- for (std::vector<const BookmarkNode*>::const_iterator iter = result.begin();
- iter != result.end();
- ++iter) {
- const BookmarkNode* bookmark = *iter;
- Java_BookmarkBridge_addToBookmarkIdList(
- env, j_result_obj, bookmark->id(), GetBookmarkType(bookmark));
- }
-}
-
void BookmarkBridge::SetBookmarkTitle(JNIEnv* env,
const JavaParamRef<jobject>& obj,
jlong id,
« no previous file with comments | « chrome/browser/android/bookmarks/bookmark_bridge.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698