[Android Bookmark] Remove all bookmark section from bookmark manager

[Android Bookmark] Remove all bookmark section from bookmark manager

This CL removes ALL_BOOKMARK state from BookmarkUIState, and cleaned up
all the related functions in bookmark manager and bridge.

After this CL, a new user will land on mobile bookmark folder
when he/she opens the bookmark manager. If he has previously opened
another folder, the bookmark manager remembers the previous folder.

BUG=605614
Committed: https://crrev.com/9aa0bf1f4c14e938f02ca7c5e7b2ec4de6c7b2b8
Cr-Commit-Position: refs/heads/master@{#391675}

[Ian Wen, 2016-05-03 22:06:43]

ianwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Ian Wen, 2016-05-03 22:06:44]

PTAL :)

[Ian Wen, 2016-05-03 22:07:28]

Description was changed from

==========
[Android Bookmark] Remove all bookmark section from bookmark manager

This CL removes ALL_BOOKMARK state from BookmarkUIState, and cleaned up
all the related functions in bookmark manager and bridge.

After this CL, a new user will always land on mobile bookmark folder
when he/she opens the bookmark manager. If he has previously opened
another folder, the bookmark manager remembers the previous folder.

BUG=605614
==========

to

==========
[Android Bookmark] Remove all bookmark section from bookmark manager

This CL removes ALL_BOOKMARK state from BookmarkUIState, and cleaned up
all the related functions in bookmark manager and bridge.

After this CL, a new user will land on mobile bookmark folder
when he/she opens the bookmark manager. If he has previously opened
another folder, the bookmark manager remembers the previous folder.

BUG=605614
==========

[gone, 2016-05-04 18:21:52]

https://chromiumcodereview.appspot.com/1935413003/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListViewAdapter.java
(right):

https://chromiumcodereview.appspot.com/1935413003/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListViewAdapter.java:37:
private List<?>[] mSections = {mTopSection, mMiddleSection};
Kind of weird to have a top and middle section but no bottom now.  Can you
rename the middle the bottom?

https://chromiumcodereview.appspot.com/1935413003/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java
(left):

https://chromiumcodereview.appspot.com/1935413003/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java:281:
RecordHistogram.recordCountHistogram("EnhancedBookmarks.AllBookmarksCount",
Edit the histogram and make it obsolete.

[gone, 2016-05-04 18:21:57]

lgtm

[Ian Wen, 2016-05-04 20:21:54]

ianwen@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Ian Wen, 2016-05-04 20:21:55]

Hi Robert: could you PTAL at the change in histogram? :)

https://codereview.chromium.org/1935413003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListViewAdapter.java
(right):

https://codereview.chromium.org/1935413003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListViewAdapter.java:37:
private List<?>[] mSections = {mTopSection, mMiddleSection};
On 2016/05/04 18:21:52, dfalcantara wrote:
> Kind of weird to have a top and middle section but no bottom now.  Can you
> rename the middle the bottom?

Good point! Done.

https://codereview.chromium.org/1935413003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java
(left):

https://codereview.chromium.org/1935413003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java:281:
RecordHistogram.recordCountHistogram("EnhancedBookmarks.AllBookmarksCount",
On 2016/05/04 18:21:52, dfalcantara wrote:
> Edit the histogram and make it obsolete.

Done.

[rkaplow, 2016-05-04 21:01:00]

lgtm

[Ian Wen, 2016-05-04 21:27:50]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-05-04 21:27:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1935413003/#ps40001
(title: "make a histogram obsolete")

[commit-bot: I haz the power, 2016-05-04 21:28:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1935413003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1935413003/40001

[commit-bot: I haz the power, 2016-05-04 22:59:24]

Description was changed from

==========
[Android Bookmark] Remove all bookmark section from bookmark manager

This CL removes ALL_BOOKMARK state from BookmarkUIState, and cleaned up
all the related functions in bookmark manager and bridge.

After this CL, a new user will land on mobile bookmark folder
when he/she opens the bookmark manager. If he has previously opened
another folder, the bookmark manager remembers the previous folder.

BUG=605614
==========

to

==========
[Android Bookmark] Remove all bookmark section from bookmark manager

This CL removes ALL_BOOKMARK state from BookmarkUIState, and cleaned up
all the related functions in bookmark manager and bridge.

After this CL, a new user will land on mobile bookmark folder
when he/she opens the bookmark manager. If he has previously opened
another folder, the bookmark manager remembers the previous folder.

BUG=605614
==========

[commit-bot: I haz the power, 2016-05-04 22:59:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-04 23:00:58]

Description was changed from

==========
[Android Bookmark] Remove all bookmark section from bookmark manager

This CL removes ALL_BOOKMARK state from BookmarkUIState, and cleaned up
all the related functions in bookmark manager and bridge.

After this CL, a new user will land on mobile bookmark folder
when he/she opens the bookmark manager. If he has previously opened
another folder, the bookmark manager remembers the previous folder.

BUG=605614
==========

to

==========
[Android Bookmark] Remove all bookmark section from bookmark manager

This CL removes ALL_BOOKMARK state from BookmarkUIState, and cleaned up
all the related functions in bookmark manager and bridge.

After this CL, a new user will land on mobile bookmark folder
when he/she opens the bookmark manager. If he has previously opened
another folder, the bookmark manager remembers the previous folder.

BUG=605614

Committed: https://crrev.com/9aa0bf1f4c14e938f02ca7c5e7b2ec4de6c7b2b8
Cr-Commit-Position: refs/heads/master@{#391675}
==========

[commit-bot: I haz the power, 2016-05-04 23:00:59]

Patchset 3 (id:??) landed as
https://crrev.com/9aa0bf1f4c14e938f02ca7c5e7b2ec4de6c7b2b8
Cr-Commit-Position: refs/heads/master@{#391675}