src/pdf/SkPDFFont.cpp - Issue 1933393002: Move SkTypeface to sk_sp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFFont.cpp

Issue 1933393002: Move SkTypeface to sk_sp. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Restore deleted Android code. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFFont.cpp

diff --git a/src/pdf/SkPDFFont.cpp b/src/pdf/SkPDFFont.cpp

index 7a66bcd1e920eebc877b9ac92e7f7b773bb94275..97be32c41da531d3ca807413ea7780bc66612576 100644

--- a/src/pdf/SkPDFFont.cpp

+++ b/src/pdf/SkPDFFont.cpp

@@ -1327,7 +1327,7 @@ SkPDFType3Font::~SkPDFType3Font() {}

bool SkPDFType3Font::populate(uint16_t glyphID) {

SkPaint paint;

- paint.setTypeface(typeface());

+ paint.setTypeface(sk_ref_sp(this->typeface()));

paint.setTextSize(1000);

const SkSurfaceProps props(0, kUnknown_SkPixelGeometry);

SkAutoGlyphCache autoCache(paint, &props, nullptr);

« no previous file with comments | « src/fonts/SkRandomScalerContext.cpp ('k') | src/ports/SkFontMgr_android.cpp » ('j') | no next file with comments »