Issue 19287006: [rAC, OSX] "Save In Chrome" checkbox.

Issue 19287006: [rAC, OSX] "Save In Chrome" checkbox. (Closed)

Created:
7 years, 5 months ago by groby-ooo-7-16

Modified:
7 years, 5 months ago

Reviewers:
Robert Sesek, Ilya Sherman

CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[rAC, OSX] "Save In Chrome" checkbox. Add a checkbox that allows to toggle the "Save In Chrome" status. Will allow rAC to save manually entered data in Chrome's autofill data. R=isherman@chromium.org, rsesek@chromium.org BUG=256862 TEST=Bring up rAC dialog, see checkbox. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211962

Patch Set 1 #

Patch Set 2 : Re-upload - CQ is capricious #

Total comments: 4

Patch Set 3 : Address review comments. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -9 lines)			Patch
M	chrome/browser/ui/autofill/mock_autofill_dialog_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/autofill/mock_autofill_dialog_controller.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/autofill/autofill_main_container.h	View	1 2	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/autofill/autofill_main_container.mm	View		4 chunks	+27 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/autofill/autofill_main_container_unittest.mm	View	1 2	3 chunks	+30 lines, -3 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

rsesek: Please look at OSX issues isherman: More mock-y goodness Screenshot: http://i.imgur.com/krFocP9.png

7 years, 5 months ago (2013-07-16 01:04:25 UTC) #1

groby-ooo-7-16

CQ, Y U HATE ME? Also, PTAL - new version uploaded and is showing properly.

7 years, 5 months ago (2013-07-16 18:27:26 UTC) #4

Robert Sesek

LGTM w/ nits https://codereview.chromium.org/19287006/diff/19001/chrome/browser/ui/cocoa/autofill/autofill_main_container.h File chrome/browser/ui/cocoa/autofill/autofill_main_container.h (right): https://codereview.chromium.org/19287006/diff/19001/chrome/browser/ui/cocoa/autofill/autofill_main_container.h#newcode80 chrome/browser/ui/cocoa/autofill/autofill_main_container.h:80: @property (readonly, nonatomic) NSButton* saveInChromeCheckboxForTesting; nit: ...

7 years, 5 months ago (2013-07-16 18:40:38 UTC) #5

groby-ooo-7-16

https://codereview.chromium.org/19287006/diff/19001/chrome/browser/ui/cocoa/autofill/autofill_main_container.h File chrome/browser/ui/cocoa/autofill/autofill_main_container.h (right): https://codereview.chromium.org/19287006/diff/19001/chrome/browser/ui/cocoa/autofill/autofill_main_container.h#newcode80 chrome/browser/ui/cocoa/autofill/autofill_main_container.h:80: @property (readonly, nonatomic) NSButton* saveInChromeCheckboxForTesting; On 2013/07/16 18:40:38, rsesek ...

7 years, 5 months ago (2013-07-16 19:55:38 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/19287006/23001

7 years, 5 months ago (2013-07-16 20:03:52 UTC) #7

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 5 months ago (2013-07-16 22:36:12 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/19287006/23001

7 years, 5 months ago (2013-07-16 22:45:05 UTC) #9

Message was sent while issue was closed.

Change committed as 211962

Expand Messages | Collapse Messages