Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 192843002: Cast:Adding signaling and infrastructure for adjustable delay (Closed)

Created:
6 years, 9 months ago by mikhal1
Modified:
6 years, 9 months ago
Reviewers:
pwestin(chromium)
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Cast:Adding signaling and infrastructure for adjustable delay Actual adjustment of the target delay will be done in a follow up cl. This cl also includes some clean-up of the rtcp types. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256757

Patch Set 1 #

Patch Set 2 : Updates #

Total comments: 10

Patch Set 3 : Responding to review #

Total comments: 1

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -128 lines) Patch
M media/cast/audio_receiver/audio_receiver.h View 3 chunks +12 lines, -4 lines 0 comments Download
M media/cast/audio_receiver/audio_receiver.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M media/cast/cast_receiver_impl.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M media/cast/cast_receiver_impl.cc View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download
M media/cast/rtcp/rtcp.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M media/cast/rtcp/rtcp.cc View 1 2 3 5 chunks +15 lines, -8 lines 0 comments Download
M media/cast/rtcp/rtcp_defines.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/rtcp/rtcp_defines.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/rtcp/rtcp_receiver.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/rtcp/rtcp_receiver_unittest.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M media/cast/rtcp/rtcp_sender.h View 1 2 chunks +5 lines, -18 lines 0 comments Download
M media/cast/rtcp/rtcp_sender.cc View 1 16 chunks +52 lines, -33 lines 0 comments Download
M media/cast/rtcp/rtcp_sender_unittest.cc View 1 14 chunks +36 lines, -26 lines 0 comments Download
M media/cast/rtcp/rtcp_utility.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/rtcp/rtcp_utility.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/rtcp/test_rtcp_packet_builder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M media/cast/rtcp/test_rtcp_packet_builder.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M media/cast/rtp_receiver/rtp_parser/include/mock/mock_rtp_feedback.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/transport/cast_transport_defines.h View 2 chunks +18 lines, -1 line 0 comments Download
M media/cast/transport/rtcp/rtcp_builder.h View 1 chunk +0 lines, -17 lines 0 comments Download
M media/cast/video_receiver/video_receiver.h View 1 2 3 chunks +11 lines, -1 line 0 comments Download
M media/cast/video_receiver/video_receiver.cc View 1 2 5 chunks +12 lines, -1 line 0 comments Download
M media/cast/video_receiver/video_receiver_unittest.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M media/cast/video_sender/video_sender.h View 1 1 chunk +1 line, -1 line 0 comments Download
M media/cast/video_sender/video_sender.cc View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mikhal1
6 years, 9 months ago (2014-03-10 16:35:51 UTC) #1
mikhal1
Please review, -Mikhal
6 years, 9 months ago (2014-03-11 17:28:27 UTC) #2
pwestin(chromium)
Missing a function in CastReceiverImpl https://chromiumcodereview.appspot.com/192843002/diff/60001/media/cast/cast_receiver_impl.cc File media/cast/cast_receiver_impl.cc (right): https://chromiumcodereview.appspot.com/192843002/diff/60001/media/cast/cast_receiver_impl.cc#newcode106 media/cast/cast_receiver_impl.cc:106: target_delay_cb_), send in your ...
6 years, 9 months ago (2014-03-11 22:07:54 UTC) #3
mikhal1
PTAL https://codereview.chromium.org/192843002/diff/60001/media/cast/cast_receiver_impl.cc File media/cast/cast_receiver_impl.cc (right): https://codereview.chromium.org/192843002/diff/60001/media/cast/cast_receiver_impl.cc#newcode106 media/cast/cast_receiver_impl.cc:106: target_delay_cb_), On 2014/03/11 22:07:55, pwestin2 wrote: > send ...
6 years, 9 months ago (2014-03-12 18:01:58 UTC) #4
pwestin(chromium)
lgtm with nit fixed https://codereview.chromium.org/192843002/diff/80001/media/cast/cast_receiver_impl.cc File media/cast/cast_receiver_impl.cc (right): https://codereview.chromium.org/192843002/diff/80001/media/cast/cast_receiver_impl.cc#newcode107 media/cast/cast_receiver_impl.cc:107: base::Unretained(this))), nit: indentation
6 years, 9 months ago (2014-03-12 21:13:54 UTC) #5
mikhal1
The CQ bit was checked by mikhal@chromium.org
6 years, 9 months ago (2014-03-12 21:38:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/192843002/100001
6 years, 9 months ago (2014-03-12 21:39:05 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 05:34:23 UTC) #8
Message was sent while issue was closed. 
Change committed as 256757

Powered by Google App Engine
This is Rietveld 408576698