Add option to output device status data in format for dashboard.

Add option to output device status data in format for dashboard and cleanup.

Adds an option to print the device status information (i.e. online devices, offline devices and device battery levels). Example output:

<*>RESULT OnlineDevices: OnlineDevices= 2
RESULT OfflineDevices: OfflineDevice= 0
RESULT DeviceBattery: 0149CC380F016011= 99
RESULT DeviceBattery: 014E378305007013= 60

Cleanup uses AndroidCommands for calling adb shell commands rather than its own GetCmdOutput function.

BUG=254014
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212052

[navabi, 2013-07-16 17:19:44]

This script will be directly called in the buildbot scripts (downstream and
upstream) as a new step. When running on the bots, the script will be wrapped up
and called via ../../../../scripts/slave/runtest.py.

[frankf, 2013-07-16 17:51:19]

https://chromiumcodereview.appspot.com/19284009/diff/1/build/android/device_s...
File build/android/device_status_check.py (right):

https://chromiumcodereview.appspot.com/19284009/diff/1/build/android/device_s...
build/android/device_status_check.py:208: print '<*>RESULT OnlineDevices:
OnlineDevices= %s' % len(devices)
You can probably use pylib/perf_tests_helper.py

https://chromiumcodereview.appspot.com/19284009/diff/1/build/android/device_s...
build/android/device_status_check.py:212: return 0
Why return here?

https://chromiumcodereview.appspot.com/19284009/diff/1/build/android/pylib/an...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/19284009/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:123: devices =
re_device.findall(cmd_helper.GetCmdOutput([constants.ADB_PATH,
just return, no intermediate var

https://chromiumcodereview.appspot.com/19284009/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:128: def IsDeviceAttached(device):
Add a doc that this only cares about online devices.

[navabi, 2013-07-16 19:01:16]

https://chromiumcodereview.appspot.com/19284009/diff/1/build/android/device_s...
File build/android/device_status_check.py (right):

https://chromiumcodereview.appspot.com/19284009/diff/1/build/android/device_s...
build/android/device_status_check.py:208: print '<*>RESULT OnlineDevices:
OnlineDevices= %s' % len(devices)
On 2013/07/16 17:51:19, frankf wrote:
> You can probably use pylib/perf_tests_helper.py

Done.

https://chromiumcodereview.appspot.com/19284009/diff/1/build/android/device_s...
build/android/device_status_check.py:212: return 0
On 2013/07/16 17:51:19, frankf wrote:
> Why return here?

The idea was that this will be a separate step from device status check that
only print dashboard data. That step will never fail, only print data to
displayed on the dashboard.

It could also be part of the device status check.

https://chromiumcodereview.appspot.com/19284009/diff/1/build/android/pylib/an...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/19284009/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:123: devices =
re_device.findall(cmd_helper.GetCmdOutput([constants.ADB_PATH,
On 2013/07/16 17:51:19, frankf wrote:
> just return, no intermediate var

Done.

https://chromiumcodereview.appspot.com/19284009/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:128: def IsDeviceAttached(device):
On 2013/07/16 17:51:19, frankf wrote:
> Add a doc that this only cares about online devices.

Done.

[frankf, 2013-07-16 19:12:54]

https://chromiumcodereview.appspot.com/19284009/diff/5002/build/android/devic...
File build/android/device_status_check.py (right):

https://chromiumcodereview.appspot.com/19284009/diff/5002/build/android/devic...
build/android/device_status_check.py:41: device_product_name =
AdbShellCommand('getprop ro.product.name')
There are existing methods in android_commands.py that do these. If something is
missing, add it there.

https://chromiumcodereview.appspot.com/19284009/diff/5002/build/android/devic...
build/android/device_status_check.py:71: '  Wifi IP: %s' %
AdbShellCommand('getprop dhcp.wlan0.ipaddress'),
Same with these.

https://chromiumcodereview.appspot.com/19284009/diff/5002/build/android/devic...
build/android/device_status_check.py:93: AdbShellCommand('reboot -p')
Also this.

[navabi, 2013-07-16 21:48:57]

https://chromiumcodereview.appspot.com/19284009/diff/5002/build/android/devic...
File build/android/device_status_check.py (right):

https://chromiumcodereview.appspot.com/19284009/diff/5002/build/android/devic...
build/android/device_status_check.py:41: device_product_name =
AdbShellCommand('getprop ro.product.name')
On 2013/07/16 19:12:54, frankf wrote:
> There are existing methods in android_commands.py that do these. If something
is
> missing, add it there.

This is calling the android_commands.py. Look at the AdbShellCommand function.
The RunShellCommand from AndroidCommands returns output in a list and we want it
as a string. The AdbShellCommand just joins the list of strings into one string.

https://chromiumcodereview.appspot.com/19284009/diff/5002/build/android/devic...
build/android/device_status_check.py:93: AdbShellCommand('reboot -p')
On 2013/07/16 19:12:54, frankf wrote:
> Also this.

Done. Added shutdown to android_commands.py

[frankf, 2013-07-16 22:02:16]

https://chromiumcodereview.appspot.com/19284009/diff/5002/build/android/devic...
File build/android/device_status_check.py (right):

https://chromiumcodereview.appspot.com/19284009/diff/5002/build/android/devic...
build/android/device_status_check.py:41: device_product_name =
AdbShellCommand('getprop ro.product.name')
I meant these:
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pyli...



On 2013/07/16 21:48:58, navabi wrote:
> On 2013/07/16 19:12:54, frankf wrote:
> > There are existing methods in android_commands.py that do these. If
something
> is
> > missing, add it there.
> 
> This is calling the android_commands.py. Look at the AdbShellCommand function.
> The RunShellCommand from AndroidCommands returns output in a list and we want
it
> as a string. The AdbShellCommand just joins the list of strings into one
string.

[navabi, 2013-07-16 23:23:17]

https://chromiumcodereview.appspot.com/19284009/diff/5002/build/android/devic...
File build/android/device_status_check.py (right):

https://chromiumcodereview.appspot.com/19284009/diff/5002/build/android/devic...
build/android/device_status_check.py:41: device_product_name =
AdbShellCommand('getprop ro.product.name')
On 2013/07/16 22:02:17, frankf wrote:
> I meant these:
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pyli...
> 
> 
> 
> On 2013/07/16 21:48:58, navabi wrote:
> > On 2013/07/16 19:12:54, frankf wrote:
> > > There are existing methods in android_commands.py that do these. If
> something
> > is
> > > missing, add it there.
> > 
> > This is calling the android_commands.py. Look at the AdbShellCommand
function.
> > The RunShellCommand from AndroidCommands returns output in a list and we
want
> it
> > as a string. The AdbShellCommand just joins the list of strings into one
> string.
> 

Done.

[navabi, 2013-07-16 23:24:27]

https://chromiumcodereview.appspot.com/19284009/diff/14001/build/android/devi...
File build/android/device_status_check.py (right):

https://chromiumcodereview.appspot.com/19284009/diff/14001/build/android/devi...
build/android/device_status_check.py:40: setup_wizard_disabled =
device_adb.RunShellCommand(
missed one. ill move this to android_commands.py too.

[frankf, 2013-07-16 23:31:58]

lgtm w/ nit

https://chromiumcodereview.appspot.com/19284009/diff/14001/build/android/devi...
File build/android/device_status_check.py (right):

https://chromiumcodereview.appspot.com/19284009/diff/14001/build/android/devi...
build/android/device_status_check.py:189:
parser.add_option('--device-status-dashboard',
No blank line above

https://chromiumcodereview.appspot.com/19284009/diff/14001/build/android/devi...
build/android/device_status_check.py:206: [len(devices)], 'devices')
Don't you want to include the serial number for each online/offline device?

[navabi, 2013-07-16 23:36:30]

Thanks Frank!

https://chromiumcodereview.appspot.com/19284009/diff/14001/build/android/devi...
File build/android/device_status_check.py (right):

https://chromiumcodereview.appspot.com/19284009/diff/14001/build/android/devi...
build/android/device_status_check.py:189:
parser.add_option('--device-status-dashboard',
On 2013/07/16 23:31:58, frankf wrote:
> No blank line above

Done.

https://chromiumcodereview.appspot.com/19284009/diff/14001/build/android/devi...
build/android/device_status_check.py:206: [len(devices)], 'devices')
On 2013/07/16 23:31:58, frankf wrote:
> Don't you want to include the serial number for each online/offline device?

It is not possible to get the serial number of offline devices. For the online
devices, their serial number will be included as part of the battery graph.

[commit-bot: I haz the power, 2013-07-17 00:08:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/19284009/24001

[commit-bot: I haz the power, 2013-07-17 15:41:09]

Change committed as 212052