Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19275015: Use a direct include of the shared_memory header in base/, chrome/, components/. (Closed)

Created:
7 years, 5 months ago by Avi (use Gerrit)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, native-client-reviews_googlegroups.com, jar (doing other things), grt+watch_chromium.org, amit, feature-media-reviews_chromium.org, robertshield, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Use a direct include of the shared_memory header in base/, chrome/, components/. BUG=260807 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M base/metrics/stats_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/stats_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_master.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc_log_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc_logging_handler_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/media/webrtc_logging_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/print_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/render_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/service_process_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_ipc_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_ipc_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/user_script_slave.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/user_script_slave.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/chrome_webrtc_log_message_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/webrtc_logging_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/mock_printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_shared_memory_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/printing/print_web_view_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/dll_redirector.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/dll_redirector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/dll_redirector_loading_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/dll_redirector_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/browser/visitedlink_event_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/browser/visitedlink_master.h View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/common/visitedlink_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/renderer/visitedlink_slave.h View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/renderer/visitedlink_slave.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/test/visitedlink_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/test/visitedlink_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/19275015/1
7 years, 5 months ago (2013-07-16 19:53:00 UTC) #1
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 06:51:26 UTC) #2
Message was sent while issue was closed. 
Change committed as 211985

Powered by Google App Engine
This is Rietveld 408576698