Issue 19272014: More PathUtilsTest.cpp nits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19272014: More PathUtilsTest.cpp nits (Closed)

Created:
7 years, 5 months ago by dierk

Modified:
7 years, 5 months ago

Reviewers:
tfarina, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

More PathUtilsTest.cpp nits Reordered the includes, changed define to a constant global var. more PathUtils Nits BUG= Committed: http://code.google.com/p/skia/source/detail?r=10110

Patch Set 1 #

Total comments: 3

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	tests/PathUtilsTest.cpp	View		4 chunks	+7 lines, -6 lines	3 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/dierk@google.com/19272014/1

7 years, 5 months ago (2013-07-16 17:31:54 UTC) #3

tfarina

7 years, 5 months ago (2013-07-16 18:08:50 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/19272014/diff/1/tests/PathUtilsTest.cpp
File tests/PathUtilsTest.cpp (right):

https://codereview.chromium.org/19272014/diff/1/tests/PathUtilsTest.cpp#newco...
tests/PathUtilsTest.cpp:17: class SkBitmap;
you don't need this forward declaration, since you already include SkBitmap.h

https://codereview.chromium.org/19272014/diff/1/tests/PathUtilsTest.cpp#newco...
tests/PathUtilsTest.cpp:21: static void fill_random_bits( int chars, char* bits
){
micro-style-nit: no need of whitespace after ( and before ), there are more
cases below.

https://codereview.chromium.org/19272014/diff/1/tests/PathUtilsTest.cpp#newco...
tests/PathUtilsTest.cpp:37: #include <iostream>
can we move this include above?

Oh, looks like all this code is commented out :(

Expand Messages | Collapse Messages