|
|
Created:
7 years, 5 months ago by mohsen Modified:
7 years, 5 months ago CC:
chromium-reviews, sadrul, ben+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionFix projection touch HUD in RTL
The projection touch HUD was shown horizontally mirrored when in
right-to-left mode. Now, fixed.
BUG=257178
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211989
Patch Set 1 #
Total comments: 2
Patch Set 2 : Applied reviews #Messages
Total messages: 17 (0 generated)
https://codereview.chromium.org/19271002/diff/1/ash/touch/touch_hud_projectio... File ash/touch/touch_hud_projection.cc (left): https://codereview.chromium.org/19271002/diff/1/ash/touch/touch_hud_projectio... ash/touch/touch_hud_projection.cc:66: SetX(touch.root_location().x() - kPointRadius - 1); Can you use: SetX(parent()->GetMirroredXInView(touch.root_location().x()) - kPointRadius - 1); instead?
https://codereview.chromium.org/19271002/diff/1/ash/touch/touch_hud_projectio... File ash/touch/touch_hud_projection.cc (left): https://codereview.chromium.org/19271002/diff/1/ash/touch/touch_hud_projectio... ash/touch/touch_hud_projection.cc:66: SetX(touch.root_location().x() - kPointRadius - 1); On 2013/07/15 21:44:06, sadrul wrote: > Can you use: > SetX(parent()->GetMirroredXInView(touch.root_location().x()) - kPointRadius - > 1); > instead? Yes, much better. Done.
LGTM
sky@: Please take a look...
LGTM
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/19271002/5001
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/19271002/5001
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/19271002/5001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/19271002/5001
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/19271002/5001
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/19271002/5001
Message was sent while issue was closed.
Change committed as 211989 |