Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 19271002: Fix projection touch HUD in RTL (Closed)

Created:
7 years, 5 months ago by mohsen
Modified:
7 years, 5 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Fix projection touch HUD in RTL The projection touch HUD was shown horizontally mirrored when in right-to-left mode. Now, fixed. BUG=257178 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211989

Patch Set 1 #

Total comments: 2

Patch Set 2 : Applied reviews #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ash/touch/touch_hud_projection.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
mohsen
7 years, 5 months ago (2013-07-15 19:41:24 UTC) #1
sadrul
https://codereview.chromium.org/19271002/diff/1/ash/touch/touch_hud_projection.cc File ash/touch/touch_hud_projection.cc (left): https://codereview.chromium.org/19271002/diff/1/ash/touch/touch_hud_projection.cc#oldcode66 ash/touch/touch_hud_projection.cc:66: SetX(touch.root_location().x() - kPointRadius - 1); Can you use: SetX(parent()->GetMirroredXInView(touch.root_location().x()) ...
7 years, 5 months ago (2013-07-15 21:44:06 UTC) #2
mohsen
https://codereview.chromium.org/19271002/diff/1/ash/touch/touch_hud_projection.cc File ash/touch/touch_hud_projection.cc (left): https://codereview.chromium.org/19271002/diff/1/ash/touch/touch_hud_projection.cc#oldcode66 ash/touch/touch_hud_projection.cc:66: SetX(touch.root_location().x() - kPointRadius - 1); On 2013/07/15 21:44:06, sadrul ...
7 years, 5 months ago (2013-07-15 22:10:52 UTC) #3
sadrul
LGTM
7 years, 5 months ago (2013-07-15 22:15:13 UTC) #4
mohsen
sky@: Please take a look...
7 years, 5 months ago (2013-07-15 22:17:47 UTC) #5
sky
LGTM
7 years, 5 months ago (2013-07-15 22:34:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/19271002/5001
7 years, 5 months ago (2013-07-15 22:35:20 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=59664
7 years, 5 months ago (2013-07-16 02:29:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/19271002/5001
7 years, 5 months ago (2013-07-16 04:04:58 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=59789
7 years, 5 months ago (2013-07-16 05:01:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/19271002/5001
7 years, 5 months ago (2013-07-16 13:58:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/19271002/5001
7 years, 5 months ago (2013-07-16 13:59:17 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=60193
7 years, 5 months ago (2013-07-16 15:08:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/19271002/5001
7 years, 5 months ago (2013-07-16 17:51:57 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=135942
7 years, 5 months ago (2013-07-16 19:28:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/19271002/5001
7 years, 5 months ago (2013-07-17 04:46:42 UTC) #16
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 07:00:18 UTC) #17
Message was sent while issue was closed.
Change committed as 211989

Powered by Google App Engine
This is Rietveld 408576698