Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1418)

Unified Diff: net/http/http_security_headers_unittest.cc

Issue 19269012: Don't persist HPKP if PrivacyMode is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address codereview nit and fix compilation error in OFFICIAL_BUILD. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_security_headers_unittest.cc
diff --git a/net/http/http_security_headers_unittest.cc b/net/http/http_security_headers_unittest.cc
index 0cc81b57eb88128f1809b9a47736720e7ea1fe88..e679b314edcfc9d55cfedd6bad2cb245714271bd 100644
--- a/net/http/http_security_headers_unittest.cc
+++ b/net/http/http_security_headers_unittest.cc
@@ -440,7 +440,7 @@ TEST_F(HttpSecurityHeadersTest, UpdateDynamicPKPOnly) {
// docs.google.com has preloaded pins.
std::string domain = "docs.google.com";
- EXPECT_TRUE(state.GetDomainState(domain, true, &domain_state));
+ EXPECT_TRUE(state.GetDomainState(domain, true, true, &domain_state));
EXPECT_GT(domain_state.static_spki_hashes.size(), 1UL);
HashValueVector saved_hashes = domain_state.static_spki_hashes;
@@ -487,7 +487,7 @@ TEST_F(HttpSecurityHeadersTest, UpdateDynamicPKPOnly) {
EXPECT_NE(dynamic_domain_state.dynamic_spki_hashes.end(), hash);
// Expect the overall state to reflect the header, too.
- EXPECT_TRUE(state.GetDomainState(domain, true, &domain_state));
+ EXPECT_TRUE(state.GetDomainState(domain, true, true, &domain_state));
EXPECT_EQ(2UL, domain_state.dynamic_spki_hashes.size());
hash = std::find_if(domain_state.dynamic_spki_hashes.begin(),

Powered by Google App Engine
This is Rietveld 408576698