Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 19267013: ash: Status Tray User Icon Update (Closed)

Created:
7 years, 5 months ago by Harry McCleave
Modified:
7 years, 5 months ago
Reviewers:
jennyz
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Status tray user icon updated for the alternate shelf layout, new icon is larger (32px instead of 27 and completely occludes the status area background behind it), has rounded corners only on the trailing edge (eg: top/bottom right when tray is horizontal, bottom left & right when vertical). BUG=245012 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211979

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -24 lines) Patch
M ash/resources/ash_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/system/tray/tray_background_view.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M ash/system/user/tray_user.cc View 1 11 chunks +76 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Harry McCleave
ptal
7 years, 5 months ago (2013-07-16 00:40:00 UTC) #1
jennyz
lgtm
7 years, 5 months ago (2013-07-16 18:31:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/19267013/2001
7 years, 5 months ago (2013-07-16 20:16:02 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 06:34:27 UTC) #4
Message was sent while issue was closed.
Change committed as 211979

Powered by Google App Engine
This is Rietveld 408576698