Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: media/blink/webmediaplayer_util.cc

Issue 1924743008: media: Report RAPPOR for media pipeline errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_util.cc
diff --git a/media/blink/webmediaplayer_util.cc b/media/blink/webmediaplayer_util.cc
index 06cd819a2c45fd4b759f3ba4b05fc28cdea772fb..e1bb4435a485c6a230ed70e1dbabcc38a5d44c75 100644
--- a/media/blink/webmediaplayer_util.cc
+++ b/media/blink/webmediaplayer_util.cc
@@ -139,6 +139,20 @@ void ReportMetrics(blink::WebMediaPlayer::LoadType load_type,
}
}
+void ReportPipelineError(blink::WebMediaPlayer::LoadType load_type,
+ const blink::WebSecurityOrigin& security_origin,
+ PipelineStatus error) {
+ DCHECK_NE(PIPELINE_OK, error);
+
+ // Report the origin from where the media player is created.
+ if (!GetMediaClient())
+ return;
+
+ GetMediaClient()->RecordRapporURL(
+ "Media.OriginUrl." + LoadTypeToString(load_type) + "PipelineError",
+ blink::WebStringToGURL(security_origin.toString()));
xhwang 2016/04/29 00:04:17 I guess we are more interested in who's failing th
xhwang 2016/04/29 00:13:14 Just FWIW, the top errors are PIPELINE_ERROR_ABOR
+}
+
void RecordOriginOfHLSPlayback(const GURL& origin_url) {
if (media::GetMediaClient())
GetMediaClient()->RecordRapporURL("Media.OriginUrl.HLS", origin_url);

Powered by Google App Engine
This is Rietveld 408576698