Issue 19244003: android/gyp/jar_toc.py: avoid specifying conflicting flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19244003: android/gyp/jar_toc.py: avoid specifying conflicting flags. (Closed)

Created:
7 years, 5 months ago by Ami GONE FROM CHROMIUM

Modified:
7 years, 5 months ago

Reviewers:
cjhopman

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android/gyp/jar_toc.py: avoid specifying conflicting flags. http://docs.oracle.com/javase/6/docs/technotes/tools/windows/javap.html says: -protected Shows only protected and public classes and members. So there's no need to specify both -protected and -public. Needed because in JDK7 javap is more particular about its flags and rejects this particular combination. BUG=https://code.google.com/p/webrtc/issues/detail?id=2034 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211700

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	build/android/gyp/jar_toc.py	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/19244003/1

7 years, 5 months ago (2013-07-15 17:35:06 UTC) #3

Message was sent while issue was closed.

Change committed as 211700

Expand Messages | Collapse Messages