Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 19240002: Copies device_status_check to the buildbot directory (Closed)

Created:
7 years, 5 months ago by gkanwar1
Modified:
7 years, 5 months ago
Reviewers:
Isaac (away), frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Copies device_status_check to the buildbot directory Once downstream scripts are updated as well, the original file can be removed, and so can pylib/buildbot_report.py BUG=258171 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211904

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
A + build/android/buildbot/bb_device_status_check.py View 5 chunks +8 lines, -6 lines 4 comments Download
M build/android/buildbot/bb_device_steps.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/utils/report_results.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
gkanwar1
7 years, 5 months ago (2013-07-15 17:10:07 UTC) #1
frankf
https://codereview.chromium.org/19240002/diff/1/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/19240002/diff/1/build/android/buildbot/bb_device_status_check.py#newcode15 build/android/buildbot/bb_device_status_check.py:15: import bb_annotations convention is to order the imports from ...
7 years, 5 months ago (2013-07-15 17:43:02 UTC) #2
gkanwar1
https://codereview.chromium.org/19240002/diff/1/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/19240002/diff/1/build/android/buildbot/bb_device_status_check.py#newcode15 build/android/buildbot/bb_device_status_check.py:15: import bb_annotations On 2013/07/15 17:43:02, frankf wrote: > convention ...
7 years, 5 months ago (2013-07-15 17:54:09 UTC) #3
frankf
lgtm
7 years, 5 months ago (2013-07-15 20:11:26 UTC) #4
gkanwar1
On 2013/07/15 20:11:26, frankf wrote: > lgtm Thanks, waiting for trybots, then will CQ.
7 years, 5 months ago (2013-07-15 20:31:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/19240002/1
7 years, 5 months ago (2013-07-15 21:14:46 UTC) #6
frankf
Please wait for ilevy
7 years, 5 months ago (2013-07-15 21:47:28 UTC) #7
gkanwar1
On 2013/07/15 21:47:28, frankf wrote: > Please wait for ilevy Oops, sorry about that.
7 years, 5 months ago (2013-07-15 21:48:16 UTC) #8
Isaac (away)
I think this one makes sense to go in buildbot/, lgtm.
7 years, 5 months ago (2013-07-15 21:49:42 UTC) #9
gkanwar1
On 2013/07/15 21:49:42, Isaac wrote: > I think this one makes sense to go in ...
7 years, 5 months ago (2013-07-15 21:51:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/19240002/1
7 years, 5 months ago (2013-07-15 21:51:09 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=59567
7 years, 5 months ago (2013-07-16 00:09:59 UTC) #12
gkanwar1
On 2013/07/16 00:09:59, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 5 months ago (2013-07-16 17:01:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/19240002/1
7 years, 5 months ago (2013-07-16 17:06:50 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=60372
7 years, 5 months ago (2013-07-16 17:55:19 UTC) #15
gkanwar1
On 2013/07/16 17:55:19, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 5 months ago (2013-07-16 20:51:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/19240002/1
7 years, 5 months ago (2013-07-16 20:53:42 UTC) #17
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=60011
7 years, 5 months ago (2013-07-17 02:09:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/19240002/1
7 years, 5 months ago (2013-07-17 02:24:55 UTC) #19
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 02:37:09 UTC) #20
Message was sent while issue was closed.
Change committed as 211904

Powered by Google App Engine
This is Rietveld 408576698