Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 19238006: Use sh instead of bash for the pre-commit hook. (Closed)

Created:
7 years, 5 months ago by Raphael Kubo da Costa (rakuco)
Modified:
7 years, 4 months ago
Reviewers:
cmp, Isaac (away), szager1
CC:
chromium-reviews
Visibility:
Public.

Description

Use sh instead of bash for the pre-commit hook. The script looks portable enough, and using sh helps on systems without bash in that specific location. R=cmp@chromium.org,szager@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/git-hooks/pre-commit View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Raphael Kubo da Costa (rakuco)
7 years, 5 months ago (2013-07-15 19:08:46 UTC) #1
Raphael Kubo da Costa (rakuco)
Ping?
7 years, 4 months ago (2013-07-29 20:58:04 UTC) #2
szager1
lgtm
7 years, 4 months ago (2013-07-29 21:05:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/19238006/1
7 years, 4 months ago (2013-07-29 21:55:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/19238006/1
7 years, 4 months ago (2013-07-30 00:28:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/19238006/1
7 years, 4 months ago (2013-07-30 10:31:39 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-07-30 20:23:44 UTC) #7
Message was sent while issue was closed.
Change committed as 214425

Powered by Google App Engine
This is Rietveld 408576698