chrome: respect --child-clean-exit.

content/app/content_main_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/app/content_main_runner.h"
 
 #include <stdlib.h>
+#include <sys/types.h>
+#include <sys/wait.h>
 
 #include "base/allocator/allocator_extension.h"
 #include "base/at_exit.h"
 #include "base/command_line.h"
 #include "base/debug/debugger.h"
 #include "base/debug/trace_event.h"
 #include "base/files/file_path.h"
 #include "base/i18n/icu_util.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
@@ skipping 761 matching lines @@
 
     _Module.Term();
 #endif  // OS_WIN
 
 #if defined(OS_MACOSX)
     autorelease_pool_.reset(NULL);
 #endif
 
     exit_manager_.reset(NULL);
 
+    // Wait for children to exit if --child-clean-exit is passed.
+    if (CommandLine::ForCurrentProcess()->
+        HasSwitch(switches::kChildCleanExit)) {
+      while (wait(NULL) != -1);

[Markus (顧孟勤), 2013/07/22 22:50:13]

Minor nit-pick (feel free to avoid).

This looks very much like an anti-pattern:
http://c-faq.com/strangeprob/emptyloop.html

I'd prefer if you were more verbose, just to make sure nobody "fixes" this code
at some point in the future.

How about:

for (;;) {
  if (wait(NULL) < 0 && errno == ECHILD) {
    break;
  }
}

This also has the advantage of looping on EINTR.

Otherwise, at least consider adding HANDLE_EINTR(wait(NULL));

[asharif1, 2013/07/22 23:43:54]

I can easily make this change, but please comment on the other issue I'm seeing,
which is described in a message along with my replies to your comments.

[asharif1, 2013/07/24 15:17:23]

Done.

+    }
+
+
     delegate_ = NULL;
     is_shutdown_ = true;
   }
 
  private:
   // True if the runner has been initialized.
   bool is_initialized_;
 
   // True if the runner has been shut down.
   bool is_shutdown_;
@@ skipping 16 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ContentMainRunnerImpl);
 };
 
 // static
 ContentMainRunner* ContentMainRunner::Create() {
   return new ContentMainRunnerImpl();
 }
 
 }  // namespace content