Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 19224003: Use a direct include of the message_loop header in base/. (Closed)

Created:
7 years, 5 months ago by Avi (use Gerrit)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, sadrul, jar (doing other things), tfarina, gavinp+memory_chromium.org, asvitkine+watch_chromium.org, erikwright+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Use a direct include of the message_loop header in base/. BUG=260807 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212281

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M base/cancelable_callback_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/deferred_sequenced_task_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_kqueue.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_util_proxy_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/files/important_file_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/libdispatch_task_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/weak_ptr_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_loop_proxy_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_loop_proxy_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_loop_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_aurax11.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop/message_pump_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_glib_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_io_ios_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/field_trial_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/observer_list_threadsafe.h View 1 chunk +1 line, -1 line 0 comments Download
M base/observer_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/power_monitor/power_monitor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_member_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/kill_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/launch_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/run_loop.h View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/cancellation_flag_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/waitable_event_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/waitable_event_watcher_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/waitable_event_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/system_monitor/system_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/system_monitor/system_monitor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/task_runner_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/sequenced_worker_pool_owner.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/timer/hi_res_timer_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/timer/timer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/tools_sanity_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/metro.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/object_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/object_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/wrapped_window_proc_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/19224003/1
7 years, 5 months ago (2013-07-16 20:23:50 UTC) #1
commit-bot: I haz the power
Failed to apply patch for base/sequence_checker_impl_unittest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
7 years, 5 months ago (2013-07-17 06:12:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/19224003/23001
7 years, 5 months ago (2013-07-17 14:12:11 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-17 14:21:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/19224003/23001
7 years, 5 months ago (2013-07-17 16:49:42 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=136581
7 years, 5 months ago (2013-07-17 20:13:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/19224003/23001
7 years, 5 months ago (2013-07-17 20:39:49 UTC) #7
commit-bot: I haz the power
Failed to apply patch for base/process_util_win.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
7 years, 5 months ago (2013-07-17 20:40:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/19224003/50001
7 years, 5 months ago (2013-07-17 20:54:58 UTC) #9
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=60877
7 years, 5 months ago (2013-07-18 03:47:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/19224003/50001
7 years, 5 months ago (2013-07-18 03:59:33 UTC) #11
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 08:12:42 UTC) #12
Message was sent while issue was closed.
Change committed as 212281

Powered by Google App Engine
This is Rietveld 408576698