Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1921553003: Move permission.mojom from WebKit/public/platform/ to components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn check fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_uma_util.h" 5 #include "chrome/browser/permissions/permission_uma_util.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/metrics/histogram_macros.h" 9 #include "base/metrics/histogram_macros.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 206
207 // In order to gauge the compatibility risk of implementing an improved 207 // In order to gauge the compatibility risk of implementing an improved
208 // iframe permissions security model, we would like to know the ratio of 208 // iframe permissions security model, we would like to know the ratio of
209 // same-origin to cross-origin permission requests. Our estimate of this 209 // same-origin to cross-origin permission requests. Our estimate of this
210 // ratio could be somewhat biased by repeated requests coming from a 210 // ratio could be somewhat biased by repeated requests coming from a
211 // single frame, but we expect this to be insignificant. 211 // single frame, but we expect this to be insignificant.
212 if (requesting_origin.GetOrigin() != embedding_origin.GetOrigin()) { 212 if (requesting_origin.GetOrigin() != embedding_origin.GetOrigin()) {
213 content::PermissionManager* manager = profile->GetPermissionManager(); 213 content::PermissionManager* manager = profile->GetPermissionManager();
214 if (!manager) 214 if (!manager)
215 return; 215 return;
216 blink::mojom::PermissionStatus embedding_permission_status = 216 permissions::mojom::PermissionStatus embedding_permission_status =
217 manager->GetPermissionStatus(permission, embedding_origin, 217 manager->GetPermissionStatus(permission, embedding_origin,
218 embedding_origin); 218 embedding_origin);
219 219
220 base::HistogramBase* histogram = base::LinearHistogram::FactoryGet( 220 base::HistogramBase* histogram = base::LinearHistogram::FactoryGet(
221 "Permissions.Requested.CrossOrigin_" + 221 "Permissions.Requested.CrossOrigin_" +
222 PermissionUtil::GetPermissionString(permission), 222 PermissionUtil::GetPermissionString(permission),
223 1, static_cast<int>(blink::mojom::PermissionStatus::LAST), 223 1, static_cast<int>(permissions::mojom::PermissionStatus::LAST),
224 static_cast<int>(blink::mojom::PermissionStatus::LAST) + 1, 224 static_cast<int>(permissions::mojom::PermissionStatus::LAST) + 1,
225 base::HistogramBase::kUmaTargetedHistogramFlag); 225 base::HistogramBase::kUmaTargetedHistogramFlag);
226 histogram->Add(static_cast<int>(embedding_permission_status)); 226 histogram->Add(static_cast<int>(embedding_permission_status));
227 } else { 227 } else {
228 UMA_HISTOGRAM_ENUMERATION( 228 UMA_HISTOGRAM_ENUMERATION(
229 "Permissions.Requested.SameOrigin", 229 "Permissions.Requested.SameOrigin",
230 static_cast<base::HistogramBase::Sample>(permission), 230 static_cast<base::HistogramBase::Sample>(permission),
231 static_cast<base::HistogramBase::Sample>(PermissionType::NUM)); 231 static_cast<base::HistogramBase::Sample>(PermissionType::NUM));
232 } 232 }
233 } 233 }
234 234
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 const std::vector<PermissionBubbleRequest*>& requests) { 280 const std::vector<PermissionBubbleRequest*>& requests) {
281 DCHECK(!requests.empty()); 281 DCHECK(!requests.empty());
282 PermissionBubbleType permission_prompt_type = PermissionBubbleType::MULTIPLE; 282 PermissionBubbleType permission_prompt_type = PermissionBubbleType::MULTIPLE;
283 if (requests.size() == 1) 283 if (requests.size() == 1)
284 permission_prompt_type = requests[0]->GetPermissionBubbleType(); 284 permission_prompt_type = requests[0]->GetPermissionBubbleType();
285 UMA_HISTOGRAM_ENUMERATION( 285 UMA_HISTOGRAM_ENUMERATION(
286 "Permissions.Prompt.Shown", 286 "Permissions.Prompt.Shown",
287 static_cast<base::HistogramBase::Sample>(permission_prompt_type), 287 static_cast<base::HistogramBase::Sample>(permission_prompt_type),
288 static_cast<base::HistogramBase::Sample>(PermissionBubbleType::NUM)); 288 static_cast<base::HistogramBase::Sample>(PermissionBubbleType::NUM));
289 } 289 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698