service/datastore/checkfilter.go - Issue 1916463004: impl/memory: Disallow empty namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/checkfilter.go

Issue 1916463004: impl/memory: Disallow empty namespace. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Rbase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/datastore/checkfilter.go

diff --git a/service/datastore/checkfilter.go b/service/datastore/checkfilter.go

index 6018a60a3dd0d9956ec31c13120b25fde16d3a1c..fe9bc57f99f3a3ea52e7f8d232b5de783e33090b 100644

--- a/service/datastore/checkfilter.go

+++ b/service/datastore/checkfilter.go

@@ -123,5 +123,6 @@ func (tcf *checkFilter) DeleteMulti(keys []*Key, cb DeleteMultiCB) error {

func applyCheckFilter(c context.Context, i RawInterface) RawInterface {

inf := info.Get(c)

- return &checkFilter{i, inf.FullyQualifiedAppID(), inf.GetNamespace()}

+ ns, _ := inf.GetNamespace()

+ return &checkFilter{i, inf.FullyQualifiedAppID(), ns}

}

« no previous file with comments | « impl/prod/raw_datastore.go ('k') | service/datastore/context.go » ('j') | no next file with comments »