impl/memory/datastore_query_execution_test.go - Issue 1916463004: impl/memory: Disallow empty namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/memory/datastore_query_execution_test.go

Issue 1916463004: impl/memory: Disallow empty namespace. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Remove memcache. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: impl/memory/datastore_query_execution_test.go

diff --git a/impl/memory/datastore_query_execution_test.go b/impl/memory/datastore_query_execution_test.go

index 41f4a898b2356b8466cb60cbffd3699ff14d83cc..941e845ebd2bb0aedeb2806e96942898f84bb9f1 100644

--- a/impl/memory/datastore_query_execution_test.go

+++ b/impl/memory/datastore_query_execution_test.go

@@ -494,7 +494,9 @@ func TestQueryExecution(t *testing.T) {

}

So(info.Get(c).FullyQualifiedAppID(), ShouldEqual, "dev~app")

- So(info.Get(c).GetNamespace(), ShouldEqual, "ns")

+ ns, has := info.Get(c).GetNamespace()

+ So(ns, ShouldEqual, "ns")

+ So(has, ShouldBeTrue)

data := ds.Get(c)

testing := data.Testable()