impl/dummy/dummy.go - Issue 1916463004: impl/memory: Disallow empty namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/dummy/dummy.go

Issue 1916463004: impl/memory: Disallow empty namespace. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Remove memcache. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: impl/dummy/dummy.go

diff --git a/impl/dummy/dummy.go b/impl/dummy/dummy.go

index dd323cd75c3856563d31577ced0e2ac641596730..43ecbe50c49b8225a33db99b5469becb63b39fe4 100644

--- a/impl/dummy/dummy.go

+++ b/impl/dummy/dummy.go

@@ -144,7 +144,7 @@ type i struct{}

func (i) AccessToken(scopes ...string) (token string, expiry time.Time, err error) { panic(ni()) }

func (i) AppID() string { return "appid" }

func (i) FullyQualifiedAppID() string { return "dummy~appid" }

-func (i) GetNamespace() string { return "dummy-namespace" }

+func (i) GetNamespace() (string, bool) { return "dummy-namespace", true }

func (i) ModuleHostname(module, version, instance string) (string, error) { panic(ni()) }

func (i) ModuleName() string { panic(ni()) }

func (i) DefaultVersionHostname() string { panic(ni()) }