Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: impl/memory/datastore_test.go

Issue 1916463004: impl/memory: Disallow empty namespace. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: impl/memory/datastore_test.go
diff --git a/impl/memory/datastore_test.go b/impl/memory/datastore_test.go
index 3a171109a2aedbda94e2ca4b1133dfeeee7bab8d..5700dad2eb96441ef08857871de3414e7f9259dc 100644
--- a/impl/memory/datastore_test.go
+++ b/impl/memory/datastore_test.go
@@ -639,7 +639,7 @@ func TestAddIndexes(t *testing.T) {
Convey("Test Testable.AddIndexes", t, func() {
ctx := UseWithAppID(context.Background(), "aid")
- namespaces := []string{"", "good", "news", "everyone"}
+ namespaces := []string{"good", "news", "everyone"}
Convey("After adding datastore entries, can query against indexes in various namespaces", func() {
foos := []*Foo{
@@ -674,7 +674,7 @@ func TestAddIndexes(t *testing.T) {
So(len(results), ShouldEqual, 2)
}
- // Add "foos" to a new namesapce, then confirm that it gets indexed.
+ // Add "foos" to a new namespace, then confirm that it gets indexed.
So(dsS.Get(infoS.Get(ctx).MustNamespace("qux")).PutMulti(foos), ShouldBeNil)
dsS.Get(ctx).Testable().CatchupIndexes()

Powered by Google App Engine
This is Rietveld 408576698