impl/memory: Disallow empty namespace.

impl/memory/memcache_test.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package memory
 
 import (
         "testing"
         "time"
 
+        infoS "github.com/luci/gae/service/info"
         mcS "github.com/luci/gae/service/memcache"
         "github.com/luci/luci-go/common/clock/testclock"
         . "github.com/luci/luci-go/common/testing/assertions"
         . "github.com/smartystreets/goconvey/convey"
         "golang.org/x/net/context"
 )
 
 func TestMemcache(t *testing.T) {
         t.Parallel()
 
@@ skipping 185 matching lines @@
                         So(mci.data.casID, ShouldEqual, 1)
 
                         testItem := &mcItem{
                                 key:   "sup",
                                 value: []byte("cool"),
                                 CasID: 1,
                         }
                         So(getItm, ShouldResemble, testItem)
                 })
 
+                Convey("When adding an item to an unset namespace", func() {
+                        _, has := infoS.Get(c).GetNamespace()
+                        So(has, ShouldBeFalse)
+
+                        item := mc.NewItem("foo").SetValue([]byte("heya"))
+                        So(mc.Set(item), ShouldBeNil)
+
+                        Convey("The item can be retrieved from the unset namespace.", func() {
+                                got, err := mc.Get("foo")
+                                So(err, ShouldBeNil)
+                                So(got.Value(), ShouldResemble, []byte("heya"))
+                        })
+
+                        Convey("The item can be retrieved from a set, empty namespace.", func() {
+                                // Now test with empty namespace.
+                                c = infoS.Get(c).MustNamespace("")
+
+                                got, err := mc.Get("foo")
+                                So(err, ShouldBeNil)
+                                So(got.Value(), ShouldResemble, []byte("heya"))
+                        })
+                })
         })
 }