impl/memory: Disallow empty namespace.

impl/memory/datastore.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package memory
 
 import (
         "errors"
         "fmt"
 
@@ skipping 36 matching lines @@
 // suitable for embedding for doing in-memory data organization.
 //
 // It's configured by default with the following settings:
 //   * AutoIndex(true)
 //   * Consistent(true)
 //   * DisableSpecialEntities(true)
 //
 // These settings can of course be changed by using the Testable() interface.
 func NewDatastore(aid, ns string) (ds.Interface, error) {
         ctx := UseWithAppID(context.Background(), aid)
-        ctx, err := info.Get(ctx).Namespace(ns)
-        if err != nil {
-                return nil, err
+        if ns != "" {
+                var err error
+                if ctx, err = info.Get(ctx).Namespace(ns); err != nil {
+                        return nil, err
+                }
         }
+
         ret := ds.Get(ctx)
         t := ret.Testable()
         t.AutoIndex(true)
         t.Consistent(true)
         t.DisableSpecialEntities(true)
         return ret, nil
 }
 
 //////////////////////////////////// dsImpl ////////////////////////////////////
 
@@ skipping 147 matching lines @@
         return countQuery(fq, d.data.parent.aid, d.ns, true, d.data.snap, d.data.snap)
 }
 
 func (*txnDsImpl) RunInTransaction(func(c context.Context) error, *ds.TransactionOptions) error {
         return errors.New("datastore: nested transactions are not supported")
 }
 
 func (*txnDsImpl) Testable() ds.Testable {
         return nil
 }