components/scheduler/renderer/renderer_scheduler_impl.cc - Issue 1914143002: Experimental 'purging and suspending' backgrounded tabs behind the flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl.cc

Issue 1914143002: Experimental 'purging and suspending' backgrounded tabs behind the flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address on haraken's review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/scheduler/renderer/renderer_scheduler_impl.h ('k') | components/scheduler/renderer/renderer_scheduler_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/renderer/renderer_scheduler_impl.cc

diff --git a/components/scheduler/renderer/renderer_scheduler_impl.cc b/components/scheduler/renderer/renderer_scheduler_impl.cc

index 5eb73a0de3a886ce5c763138e977d1e3a79e28c5..d86450f97f8f4621f5f79aacbd51c1486acb9daf 100644

--- a/components/scheduler/renderer/renderer_scheduler_impl.cc

+++ b/components/scheduler/renderer/renderer_scheduler_impl.cc

@@ -387,6 +387,17 @@ void RendererSchedulerImpl::OnRendererForegrounded() {

ResumeTimerQueueWhenForegrounded();

}

+void RendererSchedulerImpl::SuspendRenderer() {

+ helper_.CheckOnValidThread();

+ DCHECK(MainThreadOnly().renderer_backgrounded);

+ if (helper_.IsShutdown())

+ return;

+ suspend_timers_when_backgrounded_closure_.Cancel();

+ // TODO(hajimehoshi): We might need to suspend not only timer queue but also

+ // e.g. loading tasks or postMessage.

+ SuspendTimerQueueWhenBackgrounded();

void RendererSchedulerImpl::EndIdlePeriod() {

if (MainThreadOnly().in_idle_period_for_testing)

return;