IndexedDB: Coding conventions and cleanup

content/browser/indexed_db/indexed_db_transaction.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_transaction.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 32 matching lines @@
 }
 
 scoped_ptr<IndexedDBTransaction::Operation>
 IndexedDBTransaction::TaskStack::pop() {
   DCHECK(!stack_.empty());
   scoped_ptr<Operation> task(stack_.top());
   stack_.pop();
   return task.Pass();
 }
 
-scoped_refptr<IndexedDBTransaction> IndexedDBTransaction::Create(
-    int64 id,
-    scoped_refptr<IndexedDBDatabaseCallbacks> callbacks,
-    const std::vector<int64>& object_store_ids,
-    indexed_db::TransactionMode mode,
-    IndexedDBDatabase* database) {
-  std::set<int64> object_store_hash_set;

[jsbell, 2013/07/13 00:18:32]

This vector -> set conversion is replaced at the call site in
IndexedDBDatabase::CreateTransaction with: set(vec.begin(), vec.end()).

-  for (size_t i = 0; i < object_store_ids.size(); ++i)
-    object_store_hash_set.insert(object_store_ids[i]);
-
-  return make_scoped_refptr(new IndexedDBTransaction(
-      id, callbacks, object_store_hash_set, mode, database));
-}
-
 IndexedDBTransaction::IndexedDBTransaction(
     int64 id,
     scoped_refptr<IndexedDBDatabaseCallbacks> callbacks,
     const std::set<int64>& object_store_ids,
     indexed_db::TransactionMode mode,
     IndexedDBDatabase* database)
     : id_(id),
       object_store_ids_(object_store_ids),
       mode_(mode),
       state_(UNUSED),
@@ skipping 27 matching lines @@
     preemptive_task_queue_.push(task);
 
   if (abort_task)
     abort_task_stack_.push(abort_task);
 
   if (state_ == UNUSED) {
     Start();
   } else if (state_ == RUNNING && !should_process_queue_) {
     should_process_queue_ = true;
     base::MessageLoop::current()->PostTask(
-        FROM_HERE,
-        base::Bind(&IndexedDBTransaction::ProcessTaskQueue, this));
+        FROM_HERE, base::Bind(&IndexedDBTransaction::ProcessTaskQueue, this));
   }
 }
 
 void IndexedDBTransaction::Abort() {
   Abort(IndexedDBDatabaseError(WebKit::WebIDBDatabaseExceptionUnknownError,
                                "Internal error (unknown cause)"));
 }
 
 void IndexedDBTransaction::Abort(const IndexedDBDatabaseError& error) {
   IDB_TRACE("IndexedDBTransaction::Abort");
@@ skipping 61 matching lines @@
   open_cursors_.erase(cursor);
 }
 
 void IndexedDBTransaction::Run() {
   // TransactionCoordinator has started this transaction.
   DCHECK(state_ == START_PENDING || state_ == RUNNING);
   DCHECK(!should_process_queue_);
 
   should_process_queue_ = true;
   base::MessageLoop::current()->PostTask(
-      FROM_HERE,
-      base::Bind(&IndexedDBTransaction::ProcessTaskQueue, this));
+      FROM_HERE, base::Bind(&IndexedDBTransaction::ProcessTaskQueue, this));
 }
 
 void IndexedDBTransaction::Start() {
   DCHECK_EQ(state_, UNUSED);
 
   state_ = START_PENDING;
   database_->transaction_coordinator().DidStartTransaction(this);
   database_->TransactionStarted(this);
 }
 
@@ skipping 95 matching lines @@
 
 void IndexedDBTransaction::CloseOpenCursors() {
   for (std::set<IndexedDBCursor*>::iterator i = open_cursors_.begin();
        i != open_cursors_.end();
        ++i)
     (*i)->Close();
   open_cursors_.clear();
 }
 
 }  // namespace content