Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: test/mjsunit/regress/regress-2711.js

Issue 19115002: Don't use StoreIC_ArrayLength on frozen arrays (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/ic.cc ('K') | « src/ic.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/regress/regress-2711.js
diff --git a/test/mjsunit/regress/regress-235311.js b/test/mjsunit/regress/regress-2711.js
similarity index 90%
copy from test/mjsunit/regress/regress-235311.js
copy to test/mjsunit/regress/regress-2711.js
index 300714718f75e3ab084687af21aa1bf145e16678..a58e789745bc34289711ebe56270735631345b5e 100644
--- a/test/mjsunit/regress/regress-235311.js
+++ b/test/mjsunit/regress/regress-2711.js
@@ -25,8 +25,9 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-var new_space_string = "";
-for (var i = 0; i < 12800; ++i) {
- new_space_string +=
- String.fromCharCode(Math.random() * 26 + (4294967295) | 0);
-}
+// Test that frozen arrays don't let their length change
+var a = Object.freeze([1]);
+a.push(2);
ihab.awad 2013/07/12 20:41:29 Fwiw, my testing on 30.0.1562.0 canary showed that
+assertEquals(1, a.length);
+a.push(2);
+assertEquals(1, a.length);
« src/ic.cc ('K') | « src/ic.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698