Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1910773002: MD History: Fix layout of expanded search box in small windows (Closed)

Created:
4 years, 8 months ago by tsergeant
Modified:
4 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Fix layout of expanded search box in small windows Merges the center and right parts of the toolbar so that the right-aligned search bar has space when the window shrinks. BUG=605016 Committed: https://crrev.com/f39fe6fda9593beff1207a1c134192955b92de3c Cr-Commit-Position: refs/heads/master@{#390712}

Patch Set 1 #

Patch Set 2 : Rebase and add comment #

Patch Set 3 : Update comment #

Patch Set 4 : Add overlay #

Patch Set 5 : Aaaand remove it again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M chrome/browser/resources/md_history/history.html View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.html View 1 2 2 chunks +14 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
tsergeant
PTAL at the terrible things that happened while you were away.
4 years, 8 months ago (2016-04-26 05:16:46 UTC) #3
tsergeant
As discussed, I added overflow: overlay. PTAL
4 years, 7 months ago (2016-04-29 17:30:53 UTC) #4
calamity
As discussed, the overlay isn't working so I guess remove it until we figure out ...
4 years, 7 months ago (2016-04-29 18:14:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910773002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910773002/80001
4 years, 7 months ago (2016-04-29 18:20:26 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-04-29 19:12:02 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:27:44 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f39fe6fda9593beff1207a1c134192955b92de3c
Cr-Commit-Position: refs/heads/master@{#390712}

Powered by Google App Engine
This is Rietveld 408576698