Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19107003: IndexedDB: Log exception messages (Closed)

Created:
7 years, 5 months ago by jsbell
Modified:
7 years, 5 months ago
CC:
blink-reviews, dgrogan, eae+blinkwatch, dglazkov+blink, alecflett, jsbell
Visibility:
Public.

Description

IndexedDB: Log exception messages To detect regressions, log the |message| property of exceptions. BUG=95723 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154236

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+659 lines, -0 lines) Patch
M LayoutTests/storage/indexeddb/aborted-versionchange-closes-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/basics-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/basics-shared-workers-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/basics-workers-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/clone-exception-expected.txt View 3 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/create-and-remove-object-store-expected.txt View 2 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/createIndex-after-failure-expected.txt View 2 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/cursor-continue-dir-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/cursor-continue-expected.txt View 4 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/cursor-continue-validity-expected.txt View 55 chunks +55 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/cursor-finished-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/cursor-update-expected.txt View 9 chunks +12 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/database-basics-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/database-close-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/database-closepending-flag-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/deleteIndex-bug110792-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/deleteIndex-expected.txt View 2 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/deleted-objects-expected.txt View 6 chunks +64 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/exceptions-expected.txt View 33 chunks +65 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/factory-cmp-expected.txt View 1 chunk +66 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/get-keyrange-expected.txt View 3 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/index-basics-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/index-basics-workers-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/index-count-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/intversion-close-in-oncomplete-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/invalid-keys-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/key-type-array-expected.txt View 2 chunks +17 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/keypath-arrays-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/keypath-basics-expected.txt View 1 chunk +113 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/keypath-edges-expected.txt View 3 chunks +6 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/keyrange-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/mozilla/bad-keypath-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/mozilla/clear-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/mozilla/create-objectstore-basics-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/mozilla/cursors-expected.txt View 10 chunks +10 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/mozilla/readonly-transactions-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/noblobs-expected.txt View 3 chunks +9 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/object-lookups-in-versionchange-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/objectstore-autoincrement-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/objectstore-basics-expected.txt View 7 chunks +18 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/objectstore-basics-workers-expected.txt View 7 chunks +18 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/objectstore-count-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/open-cursor-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/resources/shared.js View 1 chunk +2 lines, -0 lines 1 comment Download
M LayoutTests/storage/indexeddb/structured-clone-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/transaction-abort-expected.txt View 2 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/transaction-active-flag-expected.txt View 2 chunks +33 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/transaction-after-close-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/transaction-and-objectstore-calls-expected.txt View 9 chunks +22 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/transaction-basics-expected.txt View 5 chunks +26 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/transaction-complete-workers-expected.txt View 4 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/transaction-read-only-expected.txt View 2 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/version-change-exclusive-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jsbell
This CL based on https://codereview.chromium.org/18580013/ so will need to wait for that one to land.
7 years, 5 months ago (2013-07-12 18:43:45 UTC) #1
jsbell
https://codereview.chromium.org/19107003/diff/1/LayoutTests/storage/indexeddb/resources/shared.js File LayoutTests/storage/indexeddb/resources/shared.js (right): https://codereview.chromium.org/19107003/diff/1/LayoutTests/storage/indexeddb/resources/shared.js#newcode101 LayoutTests/storage/indexeddb/resources/shared.js:101: debug("Exception message: " + e.message); This is the test ...
7 years, 5 months ago (2013-07-12 18:45:31 UTC) #2
arv (Not doing code reviews)
LGTM
7 years, 5 months ago (2013-07-12 18:49:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/19107003/1
7 years, 5 months ago (2013-07-12 20:59:56 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=12581
7 years, 5 months ago (2013-07-12 22:18:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/19107003/1
7 years, 5 months ago (2013-07-12 22:21:15 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=12604
7 years, 5 months ago (2013-07-12 23:25:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/19107003/1
7 years, 5 months ago (2013-07-12 23:32:40 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=12622
7 years, 5 months ago (2013-07-13 00:48:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/19107003/1
7 years, 5 months ago (2013-07-13 02:02:52 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=12653
7 years, 5 months ago (2013-07-13 03:04:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/19107003/1
7 years, 5 months ago (2013-07-15 16:17:18 UTC) #12
commit-bot: I haz the power
7 years, 5 months ago (2013-07-15 16:43:53 UTC) #13
Message was sent while issue was closed. 
Change committed as 154236

Powered by Google App Engine
This is Rietveld 408576698