Enable TabManager on Linux

Enable TabManager on Linux

Though MemoryPressureMonitor is not implemented on Linux, we are going
to implement a (prototype of) memory-management system in TabManager and
we need enabling TabManager on Linux.

BUG=469049, 486135, 551995
TEST=TabManagerTest.*

Committed: https://crrev.com/049996b375d9a53dcd815d5974f41cb8d8c515a0
Cr-Commit-Position: refs/heads/master@{#389719}

[hajimehoshi, 2016-04-21 11:03:17]

Description was changed from

==========
Enable TabManager on Linux

Though MemoryPressureMonitor is not implemented on Linux, we are going
to implement prototype of purge + suspend in TabManager and we need
enabling TabManager on Linux.

BUG=469049, 486135, 551995
TEST=TabManagerTest.*
==========

to

==========
Enable TabManager on Linux

Though MemoryPressureMonitor is not implemented on Linux, we are going
to implement prototype of purge + suspend in TabManager and we need
enabling TabManager on Linux.

BUG=469049, 486135, 551995
TEST=TabManagerTest.*
==========

[hajimehoshi, 2016-04-21 11:03:18]

hajimehoshi@chromium.org changed reviewers:
+ georgesak@chromium.org

[hajimehoshi, 2016-04-21 11:09:40]

Description was changed from

==========
Enable TabManager on Linux

Though MemoryPressureMonitor is not implemented on Linux, we are going
to implement prototype of purge + suspend in TabManager and we need
enabling TabManager on Linux.

BUG=469049, 486135, 551995
TEST=TabManagerTest.*
==========

to

==========
Enable TabManager on Linux

Though MemoryPressureMonitor is not implemented on Linux, we are going
to implement a (prototype of) memory-management system in TabManager and
we need enabling TabManager on Linux.

BUG=469049, 486135, 551995
TEST=TabManagerTest.*
==========

[hajimehoshi, 2016-04-21 11:09:41]

hajimehoshi@chromium.org changed reviewers:
+ sky@chromium.org

[hajimehoshi, 2016-04-21 11:09:51]

PTAL

[Georges Khalil, 2016-04-21 13:38:17]

lgtm

LGTM.

Start() is star

[Georges Khalil, 2016-04-21 13:41:13]

On 2016/04/21 13:38:17, Georges Khalil wrote:
> lgtm
> 
> LGTM.
> 
> Start() is star

Oops, pressed on the button by mistake.

As I was saying, Start() is become a mess and will require a refactoring. I
opened bug #605533 for that.

[sky, 2016-04-21 16:59:18]

https://codereview.chromium.org/1909903002/diff/20001/chrome/browser/browser_...
File chrome/browser/browser_process_impl.h (right):

https://codereview.chromium.org/1909903002/diff/20001/chrome/browser/browser_...
chrome/browser/browser_process_impl.h:334: #if defined(OS_WIN) ||
defined(OS_MACOSX) || defined(OS_LINUX) || defined(OS_CHROMEOS)
nit: you no longer need OS_CHROMEOS now that you have linux (similar comment in
other files).

https://codereview.chromium.org/1909903002/diff/20001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager.cc (right):

https://codereview.chromium.org/1909903002/diff/20001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager.cc:73: #if !defined(OS_LINUX)
In this file don't you want this to run for chromeos?

https://codereview.chromium.org/1909903002/diff/20001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager_browsertest.cc (right):

https://codereview.chromium.org/1909903002/diff/20001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_browsertest.cc:185: #if !defined(OS_LINUX)
What about chromeos?

[hajimehoshi, 2016-04-22 08:05:49]

Thank you! PTAL

https://codereview.chromium.org/1909903002/diff/20001/chrome/browser/browser_...
File chrome/browser/browser_process_impl.h (right):

https://codereview.chromium.org/1909903002/diff/20001/chrome/browser/browser_...
chrome/browser/browser_process_impl.h:334: #if defined(OS_WIN) ||
defined(OS_MACOSX) || defined(OS_LINUX) || defined(OS_CHROMEOS)
On 2016/04/21 16:59:18, sky wrote:
> nit: you no longer need OS_CHROMEOS now that you have linux (similar comment
in
> other files).

I didn't know OS_LINUX is defined on Chrome OS. Done.

https://codereview.chromium.org/1909903002/diff/20001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager.cc (right):

https://codereview.chromium.org/1909903002/diff/20001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager.cc:73: #if !defined(OS_LINUX)
On 2016/04/21 16:59:18, sky wrote:
> In this file don't you want this to run for chromeos?

Done.

https://codereview.chromium.org/1909903002/diff/20001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager_browsertest.cc (right):

https://codereview.chromium.org/1909903002/diff/20001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_browsertest.cc:185: #if !defined(OS_LINUX)
On 2016/04/21 16:59:18, sky wrote:
> What about chromeos?

Done.

[sky, 2016-04-22 15:57:07]

LGTM

https://codereview.chromium.org/1909903002/diff/40001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager_browsertest.cc (right):

https://codereview.chromium.org/1909903002/diff/40001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_browsertest.cc:184: // On Linux, a memory
pressure listener is not implemented yet.
nit: remove 'a'

[hajimehoshi, 2016-04-26 06:26:24]

Thank you!

https://codereview.chromium.org/1909903002/diff/40001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager_browsertest.cc (right):

https://codereview.chromium.org/1909903002/diff/40001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_browsertest.cc:184: // On Linux, a memory
pressure listener is not implemented yet.
On 2016/04/22 15:57:07, sky wrote:
> nit: remove 'a'

Done.

[hajimehoshi, 2016-04-26 06:26:35]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2016-04-26 06:26:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
georgesak@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1909903002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-04-26 06:26:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909903002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909903002/60001

[commit-bot: I haz the power, 2016-04-26 07:23:47]

Description was changed from

==========
Enable TabManager on Linux

Though MemoryPressureMonitor is not implemented on Linux, we are going
to implement a (prototype of) memory-management system in TabManager and
we need enabling TabManager on Linux.

BUG=469049, 486135, 551995
TEST=TabManagerTest.*
==========

to

==========
Enable TabManager on Linux

Though MemoryPressureMonitor is not implemented on Linux, we are going
to implement a (prototype of) memory-management system in TabManager and
we need enabling TabManager on Linux.

BUG=469049, 486135, 551995
TEST=TabManagerTest.*
==========

[commit-bot: I haz the power, 2016-04-26 07:23:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-26 07:24:51]

Description was changed from

==========
Enable TabManager on Linux

Though MemoryPressureMonitor is not implemented on Linux, we are going
to implement a (prototype of) memory-management system in TabManager and
we need enabling TabManager on Linux.

BUG=469049, 486135, 551995
TEST=TabManagerTest.*
==========

to

==========
Enable TabManager on Linux

Though MemoryPressureMonitor is not implemented on Linux, we are going
to implement a (prototype of) memory-management system in TabManager and
we need enabling TabManager on Linux.

BUG=469049, 486135, 551995
TEST=TabManagerTest.*

Committed: https://crrev.com/049996b375d9a53dcd815d5974f41cb8d8c515a0
Cr-Commit-Position: refs/heads/master@{#389719}
==========

[commit-bot: I haz the power, 2016-04-26 07:24:52]

Patchset 4 (id:??) landed as
https://crrev.com/049996b375d9a53dcd815d5974f41cb8d8c515a0
Cr-Commit-Position: refs/heads/master@{#389719}