chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java - Issue 1909483003: [MediaNotification] Add UMA to record user clicking media notifications

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

Issue 1909483003: [MediaNotification] Add UMA to record user clicking media notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: renaming Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

index 643cc79de0fc1bbd4aa44d8815e1195de3e30266..90cca27eba5c573323589a3f4f9dfb9984a6fb87 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

@@ -553,8 +553,10 @@ public class MediaNotificationManager {

// TODO(avayvod) work out what we should do in this case. See https://crbug.com/585395.

if (mMediaNotificationInfo.contentIntent != null) {

mNotificationBuilder.setContentIntent(PendingIntent.getActivity(mContext,

- mMediaNotificationInfo.tabId,

- mMediaNotificationInfo.contentIntent, 0));

+ mMediaNotificationInfo.tabId, mMediaNotificationInfo.contentIntent,

+ // Set FLAG_UPDATE_CURRENT so that the intent extras is updated, otherwise the

+ // intent extras will stay the same for the same tab.

gone 2016/04/20 22:17:14 1) Don't stick random comments in between a functi

Zhiqiang Zhang (Slow) 2016/04/21 10:36:47 +aberent, can you give me some details of the bug

Zhiqiang Zhang (Slow) 2016/04/21 10:37:54 +aberent, can you give me some details of the bug

Zhiqiang Zhang (Slow) 2016/04/21 16:36:52 I talked with aberent. We found the CL you mention

+ PendingIntent.FLAG_UPDATE_CURRENT));

}

mNotificationBuilder.setVisibility(