chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java - Issue 1909483003: [MediaNotification] Add UMA to record user clicking media notifications

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java

Issue 1909483003: [MediaNotification] Add UMA to record user clicking media notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: renaming Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java

index f98442b96c473cd014a3b55cd3569cd380542b6b..94c9715c25eb328f8c40d5dbf9b6ab0e91baedd9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java

@@ -15,6 +15,7 @@ import org.chromium.chrome.browser.media.remote.RemoteVideoInfo.PlayerState;

import org.chromium.chrome.browser.media.ui.MediaNotificationInfo;

import org.chromium.chrome.browser.media.ui.MediaNotificationListener;

import org.chromium.chrome.browser.media.ui.MediaNotificationManager;

+import org.chromium.chrome.browser.metrics.LaunchFromNotificationUMA;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.content_public.common.MediaMetadata;

@@ -99,7 +100,9 @@ public class CastNotificationControl implements MediaRouteController.UiListener,

// it correctly. Also add code to restore it when Chrome is resumed.

mAudioManager.requestAudioFocus(this, AudioManager.USE_DEFAULT_STREAM_TYPE,

AudioManager.AUDIOFOCUS_GAIN);

- Intent contentIntent = new Intent(mContext, ExpandedControllerActivity.class);

+ Intent contentIntent = new Intent(mContext, ExpandedControllerActivity.class)

gone 2016/04/20 22:17:14 Don't do this weird indentation if you're saving t

Zhiqiang Zhang (Slow) 2016/04/21 16:36:52 Done.

+ .putExtra(LaunchFromNotificationUMA.INTENT_EXTRA_NAME,

+ LaunchFromNotificationUMA.SOURCE_MEDIA_FLING);

mNotificationBuilder = new MediaNotificationInfo.Builder()

.setPaused(false)

.setPrivate(false)