Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1772)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

Issue 1909483003: [MediaNotification] Add UMA to record user clicking media notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: renaming Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
index 04d3061dbddddf48b5cb4477b99387f510113d4f..0484774aacbd6e2c744864ea8e3d57661b16d35a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
@@ -5,6 +5,7 @@
package org.chromium.chrome.browser.media.ui;
import android.app.Activity;
+import android.content.Intent;
import android.graphics.Bitmap;
import android.media.AudioManager;
import android.os.Build;
@@ -14,6 +15,7 @@ import org.chromium.base.ApplicationStatus;
import org.chromium.base.Log;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeFeatureList;
+import org.chromium.chrome.browser.metrics.MediaNotificationUma;
import org.chromium.chrome.browser.metrics.MediaSessionUMA;
import org.chromium.chrome.browser.tab.EmptyTabObserver;
import org.chromium.chrome.browser.tab.Tab;
@@ -111,6 +113,10 @@ public class MediaSessionTabHelper {
metadata = mFallbackMetadata;
}
+ Intent contentIntent = Tab.createBringTabToFrontIntent(mTab.getId());
+ contentIntent.putExtra(MediaNotificationUma.INTENT_EXTRA_NAME,
+ MediaNotificationUma.SOURCE_MEDIA);
+
mNotificationInfoBuilder =
new MediaNotificationInfo.Builder()
.setMetadata(metadata)
@@ -122,7 +128,7 @@ public class MediaSessionTabHelper {
.setLargeIcon(mFavicon)
.setActions(MediaNotificationInfo.ACTION_PLAY_PAUSE
| MediaNotificationInfo.ACTION_SWIPEAWAY)
- .setContentIntent(Tab.createBringTabToFrontIntent(mTab.getId()))
+ .setContentIntent(contentIntent)
.setId(R.id.media_playback_notification)
.setListener(mControlsListener);

Powered by Google App Engine
This is Rietveld 408576698