Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1672)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

Issue 1909483003: [MediaNotification] Add UMA to record user clicking media notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: renaming Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java
index 3339a72a1a560c28ada98bc4b75adfbdc26d27d5..01aff0f520427a5f498a5d3a266d9f428d2d7e83 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java
@@ -5,6 +5,7 @@
package org.chromium.chrome.browser.media.router.cast;
import android.content.Context;
+import android.content.Intent;
import com.google.android.gms.cast.ApplicationMetadata;
import com.google.android.gms.cast.Cast;
@@ -21,6 +22,7 @@ import org.chromium.chrome.R;
import org.chromium.chrome.browser.media.ui.MediaNotificationInfo;
import org.chromium.chrome.browser.media.ui.MediaNotificationListener;
import org.chromium.chrome.browser.media.ui.MediaNotificationManager;
+import org.chromium.chrome.browser.metrics.MediaNotificationUma;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.content_public.common.MediaMetadata;
@@ -139,6 +141,9 @@ public class CastSessionImpl implements MediaNotificationListener, CastSession {
});
}
+ Intent contentIntent = Tab.createBringTabToFrontIntent(tabId);
+ contentIntent.putExtra(MediaNotificationUma.INTENT_EXTRA_NAME,
+ MediaNotificationUma.SOURCE_PRESENTATION);
mNotificationBuilder = new MediaNotificationInfo.Builder()
.setPaused(false)
.setOrigin(origin)
@@ -147,7 +152,7 @@ public class CastSessionImpl implements MediaNotificationListener, CastSession {
.setTabId(tabId)
.setPrivate(isIncognito)
.setActions(MediaNotificationInfo.ACTION_STOP)
- .setContentIntent(Tab.createBringTabToFrontIntent(tabId))
+ .setContentIntent(contentIntent)
.setId(R.id.presentation_notification)
.setListener(this);
setNotificationMetadata(mNotificationBuilder);

Powered by Google App Engine
This is Rietveld 408576698