Issue 19092002: FileAPI: Change FileSystemBackend::OpenFileSystem signature

Issue 19092002: FileAPI: Change FileSystemBackend::OpenFileSystem signature (Closed)

Created:
7 years, 5 months ago by nhiroki

Modified:
7 years, 5 months ago

Reviewers:
kinuko, satorux1, tzik

CC:
chromium-reviews, vandebo (ex-Chrome), nkostylev+watch_chromium.org, Lei Zhang, tzik+watch_chromium.org, Greg Billock, tommycli, darin-cc_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

FileAPI: Change FileSystemBackend::OpenFileSystem signature This change renames FileSystemBackend::OpenFileSystem to InitializeFileSystem and makes it accept FileSystemContext object as one of its arguments. This is a preliminary change for adding SyncFileSystemBackend in the following change sets. Please see the issue for details. BUG=242422 TEST=should pass all existing tests NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211888

Patch Set 1 #

Patch Set 2 : rebase #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -32 lines)			Patch
M	chrome/browser/chromeos/fileapi/file_system_backend.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/fileapi/file_system_backend.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/media_galleries/fileapi/media_file_system_backend.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/media_galleries/fileapi/media_file_system_backend.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/copy_or_move_file_validator_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/browser/fileapi/copy_or_move_operation_delegate_unittest.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_backend.h	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_context.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/isolated_file_system_backend.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/isolated_file_system_backend.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/sandbox_file_system_backend.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/sandbox_file_system_backend.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/sandbox_file_system_backend_unittest.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/test_file_system_backend.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/test_file_system_backend.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

kinuko

We may want to change the name/signature again, but lgtm for now (no other good ...

7 years, 5 months ago (2013-07-12 10:15:36 UTC) #3

nhiroki

Hi Satoru-san, can you review c/b/chromeos/fileapi/*? Thanks!

7 years, 5 months ago (2013-07-16 02:42:29 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/19092002/12001

7 years, 5 months ago (2013-07-16 04:10:11 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/19092002/12001

7 years, 5 months ago (2013-07-16 16:08:43 UTC) #7

commit-bot: I haz the power

Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=60330

7 years, 5 months ago (2013-07-16 17:27:42 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/19092002/12001

7 years, 5 months ago (2013-07-17 00:54:17 UTC) #9

Message was sent while issue was closed.

Change committed as 211888

Expand Messages | Collapse Messages