Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: media/base/mock_filters.h

Issue 1904793002: Move Pipeline permanent callbacks into Pipeline::Client interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: restored lock during stop Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/mock_filters.h
diff --git a/media/base/mock_filters.h b/media/base/mock_filters.h
index 2f68209b74470ed9c3902ae8efa9f9c4a345c991..a30ade21b27dc9ddd57ba6928419b1d533403633 100644
--- a/media/base/mock_filters.h
+++ b/media/base/mock_filters.h
@@ -23,6 +23,7 @@
#include "media/base/pipeline_status.h"
#include "media/base/renderer.h"
#include "media/base/text_track.h"
+#include "media/base/text_track_config.h"
#include "media/base/time_source.h"
#include "media/base/video_decoder.h"
#include "media/base/video_decoder_config.h"
@@ -32,6 +33,21 @@
namespace media {
+class MockPipelineClient : public Pipeline::Client {
+ public:
+ MockPipelineClient();
+ ~MockPipelineClient() override;
+
+ MOCK_METHOD1(OnError, void(PipelineStatus));
+ MOCK_METHOD0(OnEnded, void());
+ MOCK_METHOD1(OnMetadata, void(PipelineMetadata));
+ MOCK_METHOD1(OnBufferingStateChange, void(BufferingState));
+ MOCK_METHOD0(OnDurationChange, void());
+ MOCK_METHOD2(OnAddTextTrack,
+ void(const TextTrackConfig&, const AddTextTrackDoneCB&));
+ MOCK_METHOD0(OnWaitingForDecryptionKey, void());
+};
+
class MockPipeline : public Pipeline {
public:
MockPipeline();
@@ -41,18 +57,12 @@ class MockPipeline : public Pipeline {
// take scoped_ptr* instead of scoped_ptr so that they can be mock methods.
// Private stubs for Start() and Resume() implement the actual Pipeline
// interface by forwarding to these mock methods.
- MOCK_METHOD10(Start,
- void(Demuxer*,
- std::unique_ptr<Renderer>*,
- const base::Closure&,
- const PipelineStatusCB&,
- const PipelineStatusCB&,
- const PipelineMetadataCB&,
- const BufferingStateCB&,
- const base::Closure&,
- const AddTextTrackCB&,
- const base::Closure&));
- MOCK_METHOD1(Stop, void(const base::Closure&));
+ MOCK_METHOD4(Start,
+ void(Demuxer*,
+ std::unique_ptr<Renderer>*,
+ Client*,
+ const PipelineStatusCB&));
+ MOCK_METHOD0(Stop, void());
MOCK_METHOD2(Seek, void(base::TimeDelta, const PipelineStatusCB&));
MOCK_METHOD1(Suspend, void(const PipelineStatusCB&));
MOCK_METHOD3(Resume,
@@ -83,14 +93,8 @@ class MockPipeline : public Pipeline {
// Forwarding stubs (see comment above).
void Start(Demuxer* demuxer,
std::unique_ptr<Renderer> renderer,
- const base::Closure& ended_cb,
- const PipelineStatusCB& error_cb,
- const PipelineStatusCB& seek_cb,
- const PipelineMetadataCB& metadata_cb,
- const BufferingStateCB& buffering_state_cb,
- const base::Closure& duration_change_cb,
- const AddTextTrackCB& add_text_track_cb,
- const base::Closure& waiting_for_decryption_key_cb) override;
+ Client* client,
+ const PipelineStatusCB& seek_cb) override;
void Resume(std::unique_ptr<Renderer> renderer,
base::TimeDelta timestamp,
const PipelineStatusCB& seek_cb) override;
« no previous file with comments | « media/base/BUILD.gn ('k') | media/base/mock_filters.cc » ('j') | media/base/pipeline.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698