Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: media/base/pipeline_impl_unittest.cc

Issue 1904793002: Move Pipeline permanent callbacks into Pipeline::Client interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed permanent callbacks Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/pipeline_impl_unittest.cc
diff --git a/media/base/pipeline_impl_unittest.cc b/media/base/pipeline_impl_unittest.cc
index d08ecf1c173c58526069edb5d0c1cf23059e88ad..5166202de2c3f726e54837e2600907bfa09a7cfc 100644
--- a/media/base/pipeline_impl_unittest.cc
+++ b/media/base/pipeline_impl_unittest.cc
@@ -19,6 +19,7 @@
#include "media/base/gmock_callback_support.h"
#include "media/base/media_log.h"
#include "media/base/mock_filters.h"
+#include "media/base/pipeline_client.h"
#include "media/base/test_helpers.h"
#include "media/base/text_renderer.h"
#include "media/base/text_track_config.h"
@@ -97,8 +98,9 @@ class PipelineImplTest : public ::testing::Test {
};
PipelineImplTest()
- : pipeline_(
- new PipelineImpl(message_loop_.task_runner(), new MediaLog())),
+ : pipeline_(new PipelineImpl(&pipeline_client_,
+ message_loop_.task_runner(),
+ new MediaLog())),
demuxer_(new StrictMock<MockDemuxer>()),
scoped_renderer_(new StrictMock<MockRenderer>()),
renderer_(scoped_renderer_.get()) {
@@ -360,6 +362,7 @@ class PipelineImplTest : public ::testing::Test {
StrictMock<CallbackHelper> callbacks_;
base::SimpleTestTickClock test_tick_clock_;
base::MessageLoop message_loop_;
+ MockPipelineClient pipeline_client_;
scoped_ptr<PipelineImpl> pipeline_;
scoped_ptr<StrictMock<MockDemuxer>> demuxer_;

Powered by Google App Engine
This is Rietveld 408576698