Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 1904793002: Move Pipeline permanent callbacks into Pipeline::Client interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.h
diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h
index 59b021f0e1c1764d98c83ac5a7770d78aba58c2b..2f0f02a73b8e94cdc724a3c82a9bbe12ba841211 100644
--- a/media/blink/webmediaplayer_impl.h
+++ b/media/blink/webmediaplayer_impl.h
@@ -81,6 +81,7 @@ class WebTextTrackImpl;
class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
: public NON_EXPORTED_BASE(blink::WebMediaPlayer),
public NON_EXPORTED_BASE(WebMediaPlayerDelegate::Observer),
+ public NON_EXPORTED_BASE(Pipeline::Client),
public base::SupportsWeakPtr<WebMediaPlayerImpl> {
public:
// Constructs a WebMediaPlayer implementation using Chromium's media stack.
@@ -223,13 +224,17 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
friend class WebMediaPlayerImplTest;
void OnPipelineSuspended();
- void OnPipelineEnded();
- void OnPipelineError(PipelineStatus error);
- void OnPipelineMetadata(PipelineMetadata metadata);
- void OnPipelineBufferingStateChanged(BufferingState buffering_state);
void OnDemuxerOpened();
+
+ // Pipeline::Client overrides.
+ void OnError(PipelineStatus status) override;
+ void OnEnded() override;
+ void OnMetadata(PipelineMetadata metadata) override;
+ void OnBufferingStateChange(BufferingState state) override;
+ void OnDurationChange() override;
void OnAddTextTrack(const TextTrackConfig& config,
- const AddTextTrackDoneCB& done_cb);
+ const AddTextTrackDoneCB& done_cb) override;
+ void OnWaitingForDecryptionKey() override;
// Actually seek. Avoids causing |should_notify_time_changed_| to be set when
// |time_updated| is false.
@@ -267,7 +272,6 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
double GetPipelineDuration() const;
// Callbacks from |pipeline_| that are forwarded to |client_|.
- void OnDurationChanged();
void OnNaturalSizeChanged(gfx::Size size);
void OnOpacityChanged(bool opaque);
@@ -288,10 +292,6 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
// tracks separately in WebSourceBufferImpl.
void OnFFmpegMediaTracksUpdated(scoped_ptr<MediaTracks> tracks);
- // Called when a decoder detects that the key needed to decrypt the stream
- // is not available.
- void OnWaitingForDecryptionKey();
-
// Sets |cdm_context| on the pipeline and fires |cdm_attached_cb| when done.
// Parameter order is reversed for easy binding.
void SetCdm(const CdmAttachedCB& cdm_attached_cb, CdmContext* cdm_context);

Powered by Google App Engine
This is Rietveld 408576698