Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 19041004: Move max vibration duration constant to platform so content/ can read it. (Closed)

Created:
7 years, 5 months ago by Michael van Ouwerkerk
Modified:
7 years, 5 months ago
Reviewers:
jam, abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move max vibration duration constant to platform so content/ can read it. BUG=222504 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M Source/modules/vibration/NavigatorVibration.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
A + public/platform/WebVibration.h View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael van Ouwerkerk
The idea of sharing this constant was raised during review of this patch: https://codereview.chromium.org/16781002/
7 years, 5 months ago (2013-07-11 12:51:16 UTC) #1
jam
(note i'm not a webkit reviewer, so I defer to abarth)
7 years, 5 months ago (2013-07-11 14:52:32 UTC) #2
abarth-chromium
lgtm
7 years, 5 months ago (2013-07-11 17:19:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/19041004/1
7 years, 5 months ago (2013-07-11 17:19:45 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 18:01:20 UTC) #5
Message was sent while issue was closed.
Change committed as 154029

Powered by Google App Engine
This is Rietveld 408576698