[Android] Convert more test targets to use isolate.

[Android] Convert more test targets to use isolate.

BUG=249870
TBR=ben@chromium.org, acolwell@chromium.org, joi@chromium.org, enne@chromium.org, mark@chromium.org, jam@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211547

[frankf, 2013-07-11 18:40:59]

ptal. This is dependent on crrev.com/18233018 landing first.

[M-A Ruel, 2013-07-11 19:07:23]

https://codereview.chromium.org/19040002/diff/4001/breakpad/breakpad_unittest...
File breakpad/breakpad_unittests.isolate (right):

https://codereview.chromium.org/19040002/diff/4001/breakpad/breakpad_unittest...
breakpad/breakpad_unittests.isolate:8: 'isolate_dependency_untracked': [
s/untracked/tracked/ in every .isolate file when relevant, e.g. it's a file, not
a directory.

https://codereview.chromium.org/19040002/diff/4001/cc/cc_perftests.isolate
File cc/cc_perftests.isolate (right):

https://codereview.chromium.org/19040002/diff/4001/cc/cc_perftests.isolate#ne...
cc/cc_perftests.isolate:5: 'conditions': [
Probably worth re-uploading with --similarity 90

https://codereview.chromium.org/19040002/diff/4001/content/content_browsertes...
File content/content_browsertests.isolate (right):

https://codereview.chromium.org/19040002/diff/4001/content/content_browsertes...
content/content_browsertests.isolate:5: 'conditions': [
FYI, that file was in a previous format so this is why the diff is a bit more
convoluted. Upgraded the file was needed anyhow.

https://codereview.chromium.org/19040002/diff/4001/content/content_browsertes...
content/content_browsertests.isolate:10:
'<(PRODUCT_DIR)/content_shell/assets/content_shell.pak',
Tracked

https://codereview.chromium.org/19040002/diff/4001/content/content_unittests....
File content/content_unittests.isolate (right):

https://codereview.chromium.org/19040002/diff/4001/content/content_unittests....
content/content_unittests.isolate:10: '../third_party/hyphen/hyph_en_US.dic',
This one is tracked.

https://codereview.chromium.org/19040002/diff/4001/content/content_unittests....
content/content_unittests.isolate:46: 'isolate_dependency_untracked': [
That's weird that it was in untracked in the first place. That was probably
edited manually when it was first checked in. Do s/untracked/tracked/ everywhere
relevant.

[frankf, 2013-07-11 20:32:25]

ptal

https://codereview.chromium.org/19040002/diff/4001/breakpad/breakpad_unittest...
File breakpad/breakpad_unittests.isolate (right):

https://codereview.chromium.org/19040002/diff/4001/breakpad/breakpad_unittest...
breakpad/breakpad_unittests.isolate:8: 'isolate_dependency_untracked': [
On 2013/07/11 19:07:23, Marc-Antoine Ruel wrote:
> s/untracked/tracked/ in every .isolate file when relevant, e.g. it's a file,
not
> a directory.

Done.

https://codereview.chromium.org/19040002/diff/4001/cc/cc_perftests.isolate
File cc/cc_perftests.isolate (right):

https://codereview.chromium.org/19040002/diff/4001/cc/cc_perftests.isolate#ne...
cc/cc_perftests.isolate:5: 'conditions': [
On 2013/07/11 19:07:23, Marc-Antoine Ruel wrote:
> Probably worth re-uploading with --similarity 90

Done.

https://codereview.chromium.org/19040002/diff/4001/content/content_browsertes...
File content/content_browsertests.isolate (right):

https://codereview.chromium.org/19040002/diff/4001/content/content_browsertes...
content/content_browsertests.isolate:10:
'<(PRODUCT_DIR)/content_shell/assets/content_shell.pak',
On 2013/07/11 19:07:23, Marc-Antoine Ruel wrote:
> Tracked

Done.

https://codereview.chromium.org/19040002/diff/4001/content/content_unittests....
File content/content_unittests.isolate (right):

https://codereview.chromium.org/19040002/diff/4001/content/content_unittests....
content/content_unittests.isolate:10: '../third_party/hyphen/hyph_en_US.dic',
On 2013/07/11 19:07:23, Marc-Antoine Ruel wrote:
> This one is tracked.

Done.

https://codereview.chromium.org/19040002/diff/4001/content/content_unittests....
content/content_unittests.isolate:46: 'isolate_dependency_untracked': [
On 2013/07/11 19:07:23, Marc-Antoine Ruel wrote:
> That's weird that it was in untracked in the first place. That was probably
> edited manually when it was first checked in. Do s/untracked/tracked/
everywhere
> relevant.

Done.

[craigdh, 2013-07-11 21:24:28]

changes to build/android/pylib/ lgtm.

[bulach, 2013-07-12 09:40:42]

lgtm for build/android, thanks!

[M-A Ruel, 2013-07-12 17:38:46]

Terrific, thanks for the clean up.

lgtm

[commit-bot: I haz the power, 2013-07-12 19:11:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/frankf@chromium.org/19040002/21001

[commit-bot: I haz the power, 2013-07-12 19:25:18]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-07-12 20:30:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/frankf@chromium.org/19040002/34001

[commit-bot: I haz the power, 2013-07-13 04:43:56]

Change committed as 211547

[jam, 2013-07-16 04:17:21]

lgtm, thanks