Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 19027005: Hide notifications popups when entering fullscreen mode. (Closed)

Created:
7 years, 5 months ago by dewittj
Modified:
7 years, 4 months ago
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Mac][Win] Hide notifications popups when entering fullscreen mode. They currently remain until expiration which could be forever in the case of webkit notifications. TODO: chromeos. R=mukai@chromium.org, stevenjb@chromium.org TBR=johnnyg@chromium.org BUG=233752 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215784

Patch Set 1 : #

Patch Set 2 : Adds a test. #

Patch Set 3 : Add ChromeOS support. #

Total comments: 1

Patch Set 4 : Rebase, remove ash functionality. #

Patch Set 5 : Fixup test #ifdef #

Patch Set 6 : Fix remaining testing issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -8 lines) Patch
M ash/system/web_notification/web_notification_tray.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.h View 1 2 3 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.cc View 1 2 3 4 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/notifications/message_center_notifications_browsertest.cc View 1 2 3 4 5 3 chunks +29 lines, -0 lines 0 comments Download
M chrome/browser/notifications/message_center_notifications_unittest_win.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager_impl.h View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.mm View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M ui/message_center/message_center_tray_delegate.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/message_center/message_center_tray_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dewittj
7 years, 5 months ago (2013-07-12 22:40:43 UTC) #1
Jun Mukai
https://codereview.chromium.org/19027005/diff/16001/ash/wm/workspace/workspace_manager.cc File ash/wm/workspace/workspace_manager.cc (right): https://codereview.chromium.org/19027005/diff/16001/ash/wm/workspace/workspace_manager.cc#newcode694 ash/wm/workspace/workspace_manager.cc:694: if (full_count > 0) { It is not very ...
7 years, 5 months ago (2013-07-13 00:51:16 UTC) #2
dewittj
Resurrecting this old patchset, removed the ChromeOS functionality so I can land this. PTAL.
7 years, 4 months ago (2013-08-05 20:22:04 UTC) #3
Jun Mukai
On 2013/08/05 20:22:04, dewittj wrote: > Resurrecting this old patchset, removed the ChromeOS functionality so ...
7 years, 4 months ago (2013-08-05 20:44:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/19027005/37002
7 years, 4 months ago (2013-08-06 00:34:15 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 03:57:55 UTC) #6
Message was sent while issue was closed.
Change committed as 215784

Powered by Google App Engine
This is Rietveld 408576698