Issue 19027002: Fix pylint presubmit failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19027002: Fix pylint presubmit failure (Closed)

Created:
7 years, 5 months ago by Isaac (away)

Modified:
7 years, 5 months ago

Reviewers:
tapted, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Fix pylint presubmit failure Caused by crrev.com/210695 TBR=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=210949

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	git_cl.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/19027002/1

7 years, 5 months ago (2013-07-10 22:14:37 UTC) #1

tapted

7 years, 5 months ago (2013-07-10 22:59:21 UTC) #3

Message was sent while issue was closed.

lgtm - thanks. Odd that the presubmit didn't pick it up on my mac.  I'll see if
I can figure out why.. since it did run, and it's blocked me in the past.

Expand Messages | Collapse Messages