build/android/pylib/instrumentation/dispatch.py - Issue 19021003: Fixes dispatch files to return exit codes in several places

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/dispatch.py

Issue 19021003: Fixes dispatch files to return exit codes in several places (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/instrumentation/dispatch.py

diff --git a/build/android/pylib/instrumentation/dispatch.py b/build/android/pylib/instrumentation/dispatch.py

index df245c73538bf5d74fd0df1bcb531546950d4038..e4ca2805243c6edb7f02830ae28bd808256ef6df 100644

--- a/build/android/pylib/instrumentation/dispatch.py

+++ b/build/android/pylib/instrumentation/dispatch.py

@@ -8,6 +8,7 @@ import logging

import os

from pylib import android_commands

+from pylib import constants

from pylib.base import base_test_result

from pylib.base import shard

from pylib.utils import report_results

@@ -36,8 +37,8 @@ def Dispatch(options):

tests = test_pkg._GetAllMatchingTests(

options.annotations, options.exclude_annotations, options.test_filter)

if not tests:

- logging.warning('No instrumentation tests to run with current args.')

- return base_test_result.TestRunResults()

+ logging.error('No instrumentation tests to run with current args.')

+ return (base_test_result.TestRunResults(), constants.ERROR_EXIT_CODE)

attached_devices = android_commands.GetAttachedDevices()

if not attached_devices:

« no previous file with comments | « build/android/pylib/gtest/dispatch.py ('k') | build/android/pylib/uiautomator/dispatch.py » ('j') | no next file with comments »