Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 19019002: Ensure that ArrayBuffers actively being used by the Web Audio API cannot be neutered (Closed)

Created:
7 years, 5 months ago by Chris Rogers
Modified:
7 years, 5 months ago
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez, cbiesinger
Visibility:
Public.

Description

Ensure that ArrayBuffers actively being used by the Web Audio API cannot be neutered In the unusual case when such ArrayBuffers are used with web workers, they will be copied instead of transferred. For performance reasons, it's important to *not* involve any copying of these buffers during normal use of the Web Audio API. BUG=254728 TEST=webaudio/audiobuffer-neuter.html TBR=dslomov@chromium.org, kbr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153973 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154439

Patch Set 1 #

Patch Set 2 : rebase for re-landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -6 lines) Patch
A LayoutTests/webaudio/audiobuffer-neuter.html View 1 chunk +79 lines, -0 lines 0 comments Download
A LayoutTests/webaudio/audiobuffer-neuter-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/webaudio/AudioBuffer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioBuffer.cpp View 1 3 chunks +5 lines, -2 lines 0 comments Download
M Source/wtf/ArrayBuffer.cpp View 1 chunk +15 lines, -2 lines 0 comments Download
M Source/wtf/ArrayBufferContents.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/ArrayBufferContents.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M Source/wtf/ArrayBufferView.h View 2 chunks +5 lines, -1 line 0 comments Download
M Source/wtf/ArrayBufferView.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Chris Rogers
7 years, 5 months ago (2013-07-10 20:43:07 UTC) #1
Dmitry Lomov (no reviews)
lgtm with caveats I explained in the bug (need better fix for M30)
7 years, 5 months ago (2013-07-10 20:50:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/crogers@google.com/19019002/1
7 years, 5 months ago (2013-07-10 21:17:15 UTC) #3
Ken Russell (switch to Gerrit)
lgtm with the same caveats.
7 years, 5 months ago (2013-07-10 21:22:58 UTC) #4
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=3285
7 years, 5 months ago (2013-07-10 21:53:54 UTC) #5
Ken Russell (switch to Gerrit)
Looks like you need either another review or to use TBR.
7 years, 5 months ago (2013-07-10 22:07:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/crogers@google.com/19019002/1
7 years, 5 months ago (2013-07-10 22:24:32 UTC) #7
commit-bot: I haz the power
Change committed as 153973
7 years, 5 months ago (2013-07-11 03:49:08 UTC) #8
Chris Rogers
Committed patchset #2 manually as r154439 (presubmit successful).
7 years, 5 months ago (2013-07-17 22:32:06 UTC) #9
gavinp
7 years, 5 months ago (2013-07-18 16:32:40 UTC) #10

Powered by Google App Engine
This is Rietveld 408576698