Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 19006002: Flag rewriting an IC while writing to a global constant property as a failure caused by the constan… (Closed)

Created:
7 years, 5 months ago by Toon Verwaest
Modified:
7 years, 5 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Flag rewriting an IC while writing to a global constant property as a failure caused by the constant property turning mutable. R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/ic.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 5 months ago (2013-07-10 16:04:19 UTC) #1
danno
lgtm
7 years, 5 months ago (2013-07-10 16:06:17 UTC) #2
Toon Verwaest
7 years, 5 months ago (2013-07-10 16:06:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15606 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698