Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: src/ic.cc

Issue 19005002: Allow NORMAL ICs to go polymorphic. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove debug break Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index dc15194ec94432419b73f1d8c74bcad458e5c305..c3ed767d9f6cd7581beb4537e05c8cc770c7c353 100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -978,12 +978,6 @@ bool IC::UpdatePolymorphicIC(State state,
Handle<String> name,
Handle<Code> code,
StrictModeFlag strict_mode) {
- if (code->type() == Code::NORMAL) return false;
- if (target()->ic_state() == MONOMORPHIC &&
- target()->type() == Code::NORMAL) {
- return false;
- }
-
MapHandleList receiver_maps;
CodeHandleList handlers;
@@ -992,7 +986,12 @@ bool IC::UpdatePolymorphicIC(State state,
Handle<Map> new_receiver_map(receiver->map());
{
DisallowHeapAllocation no_gc;
- target()->FindAllMaps(&receiver_maps);
+ if (target()->ic_state() == POLYMORPHIC ||
+ (target()->ic_state() == MONOMORPHIC &&
+ target()->type() != Code::NORMAL)) {
+ target()->FindAllMaps(&receiver_maps);
+ }
+
int number_of_maps = receiver_maps.length();
number_of_valid_maps = number_of_maps;
@@ -1012,12 +1011,9 @@ bool IC::UpdatePolymorphicIC(State state,
if (number_of_valid_maps >= 4) return false;
- // Only allow 0 maps in case target() was reset to UNINITIALIZED by the GC.
- // In that case, allow the IC to go back monomorphic.
- if (number_of_maps == 0 && target()->ic_state() != UNINITIALIZED) {
- return false;
+ if (number_of_maps > 0) {
+ target()->FindAllCode(&handlers, receiver_maps.length());
}
- target()->FindAllCode(&handlers, receiver_maps.length());
}
number_of_valid_maps++;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698