Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 18998002: add missing includes in gpu/command_buffer/* (Closed)

Created:
7 years, 5 months ago by Mostyn Bramley-Moore
Modified:
7 years, 5 months ago
CC:
chromium-reviews, apatrick_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

add missing includes in gpu/command_buffer/* gpu/command_buffer/service/command_buffer_service.cc uses DCHECK* but doesn't include base/logging.h Similarly in gpu/command_buffer/service/transfer_buffer_manager.cc, which also lacks scoped_ptr.h. BUG=259043 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210963

Patch Set 1 #

Patch Set 2 : add more missing includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gpu/command_buffer/service/command_buffer_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/transfer_buffer_manager.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mostyn Bramley-Moore
@greggman: does this trivial patch look OK to you?
7 years, 5 months ago (2013-07-10 11:55:55 UTC) #1
apatrick_chromium
lgtm
7 years, 5 months ago (2013-07-10 18:08:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/18998002/2001
7 years, 5 months ago (2013-07-10 18:13:42 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-10 18:19:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/18998002/2001
7 years, 5 months ago (2013-07-10 18:22:14 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-10 20:55:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/18998002/2001
7 years, 5 months ago (2013-07-10 20:57:22 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-10 23:17:15 UTC) #8
Message was sent while issue was closed.
Change committed as 210963

Powered by Google App Engine
This is Rietveld 408576698