Unset some environment vars so they can be set up via the bisect script.

Unset some environment vars so they can be set up via the bisect script.

BUG=
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211214

[shatch, 2013-07-10 23:55:42]

https://codereview.chromium.org/18991015/diff/1/build/android/buildbot/bb_hos...
File build/android/buildbot/bb_host_steps.py (left):

https://codereview.chromium.org/18991015/diff/1/build/android/buildbot/bb_hos...
build/android/buildbot/bb_host_steps.py:104: '-p', bb_utils.GOMA_DIR])
Strangely, building with goma was really slow so I took it out.

[tonyg, 2013-07-11 01:34:28]

lgtm

https://codereview.chromium.org/18991015/diff/1/tools/bisect-perf-regression.py
File tools/bisect-perf-regression.py (right):

https://codereview.chromium.org/18991015/diff/1/tools/bisect-perf-regression....
tools/bisect-perf-regression.py:358: threads = 0
None instead of 0?

https://codereview.chromium.org/18991015/diff/1/tools/bisect-perf-regression....
tools/bisect-perf-regression.py:411: targets = ['chromium_testshell',
'content_shell_apk', 'forwarder2',
I think the target is chromium_testshell_test_apk, right? Also, can we totally
remove content_shell_apk?

https://codereview.chromium.org/18991015/diff/1/tools/bisect_utils.py
File tools/bisect_utils.py (right):

https://codereview.chromium.org/18991015/diff/1/tools/bisect_utils.py#newcode354
tools/bisect_utils.py:354: CopyAndSaveOriginalEnvironmentVars()
Kinda gross, but ok

[bulach, 2013-07-11 14:52:58]

quick clarification:

https://codereview.chromium.org/18991015/diff/1/tools/bisect-perf-regression.py
File tools/bisect-perf-regression.py (right):

https://codereview.chromium.org/18991015/diff/1/tools/bisect-perf-regression....
tools/bisect-perf-regression.py:411: targets = ['chromium_testshell',
'content_shell_apk', 'forwarder2',
On 2013/07/11 01:34:28, tonyg wrote:
> I think the target is chromium_testshell_test_apk, right? Also, can we totally
> remove content_shell_apk?

drive-by:
chromium_testshell is the "app", that is, similar level as "chrome" and "content
shell".
chromium_testshell_test_apk is the instrumentation tests for the app.

[shatch, 2013-07-11 20:51:05]

New snapshot uploaded.

https://codereview.chromium.org/18991015/diff/1/tools/bisect-perf-regression.py
File tools/bisect-perf-regression.py (right):

https://codereview.chromium.org/18991015/diff/1/tools/bisect-perf-regression....
tools/bisect-perf-regression.py:358: threads = 0
On 2013/07/11 01:34:28, tonyg wrote:
> None instead of 0?

Done.

https://codereview.chromium.org/18991015/diff/1/tools/bisect-perf-regression....
tools/bisect-perf-regression.py:411: targets = ['chromium_testshell',
'content_shell_apk', 'forwarder2',
On 2013/07/11 14:52:58, bulach wrote:
> On 2013/07/11 01:34:28, tonyg wrote:
> > I think the target is chromium_testshell_test_apk, right? Also, can we
totally
> > remove content_shell_apk?
> 
> drive-by:
> chromium_testshell is the "app", that is, similar level as "chrome" and
"content
> shell".
> chromium_testshell_test_apk is the instrumentation tests for the app.

Ok, so chromium_testshell is the correct one to build?

https://codereview.chromium.org/18991015/diff/1/tools/bisect-perf-regression....
tools/bisect-perf-regression.py:411: targets = ['chromium_testshell',
'content_shell_apk', 'forwarder2',
On 2013/07/11 01:34:28, tonyg wrote:
> I think the target is chromium_testshell_test_apk, right? Also, can we totally
> remove content_shell_apk?

Done.

[commit-bot: I haz the power, 2013-07-11 21:10:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simonhatch@chromium.org/18991015/56294...

[commit-bot: I haz the power, 2013-07-11 21:10:44]

Change committed as 211214