Issue 18986003: Don't fast-store to observed objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18986003: Don't fast-store to observed objects. (Closed)

Created:
7 years, 5 months ago by Toon Verwaest

Modified:
7 years, 5 months ago

Reviewers:
Dmitry Lomov (no reviews), adamk

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Edit: Closed since the solution isn't exactly the best. Filed bug 2774; will disable the relevant test.

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/hydrogen.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

PTAL. This is a fix for the bug in Object.observe StoreNamedField exposed by https://chromiumcodereview.appspot.com/17432004. As ...

7 years, 5 months ago (2013-07-10 09:13:37 UTC) #1

Dmitry Lomov (no reviews)

7 years, 5 months ago (2013-07-10 09:15:51 UTC) #2

Change looks good. How about at least a minimal test?

On 2013/07/10 09:13:37, Toon Verwaest wrote:
> PTAL.
> 
> This is a fix for the bug in Object.observe StoreNamedField exposed by
> https://chromiumcodereview.appspot.com/17432004. As far as I can tell stores
to
> fields aren't properly observed at all in crankshaft. If so, there's missing
> test coverage for crankshaft.

Expand Messages | Collapse Messages