Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: components/dom_distiller/core/distilled_content_store.h

Issue 189833002: Add a DistilledContentStore (and an in-memory impl) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/core/distilled_content_store.h
diff --git a/components/dom_distiller/core/distilled_content_store.h b/components/dom_distiller/core/distilled_content_store.h
new file mode 100644
index 0000000000000000000000000000000000000000..27a3c3026d319a4485e1069adfccb39322e11aed
--- /dev/null
+++ b/components/dom_distiller/core/distilled_content_store.h
@@ -0,0 +1,54 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_CONTENT_STORE_H_
+#define COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_CONTENT_STORE_H_
+
+#include "base/bind.h"
+#include "base/containers/hash_tables.h"
+#include "components/dom_distiller/core/article_entry.h"
+#include "components/dom_distiller/core/proto/distilled_article.pb.h"
+
+namespace dom_distiller {
+
+// This is a simple interface for saving and loading of distilled content for an
+// ArticleEntry.
+class DistilledContentStore {
+ public:
+ typedef base::Callback<
+ void(bool /* success */, scoped_ptr<DistilledArticleProto>)> LoadCallback;
+ typedef base::Callback<void(bool /* success */)> SaveCallback;
+
+ virtual void SaveContent(const ArticleEntry& entry,
+ const DistilledArticleProto& proto,
+ SaveCallback callback) = 0;
+ virtual void LoadContent(const ArticleEntry& entry,
shashi 2014/03/18 21:14:57 nit: Can this method be const? i.e. LoadContent ju
cjhopman 2014/04/11 22:37:21 Done.
+ LoadCallback callback) = 0;
+
+ virtual ~DistilledContentStore() {}
shashi 2014/03/18 21:14:57 DISALLOW_COPY_AND_ASSIGN(DistilledContentStore);
cjhopman 2014/04/11 22:37:21 Done.
+};
+
+class InMemoryContentStore : public DistilledContentStore {
+ public:
+ InMemoryContentStore();
+ virtual ~InMemoryContentStore();
+
+ // DistilledContentStore implementation
+ virtual void SaveContent(const ArticleEntry& entry,
+ const DistilledArticleProto& proto,
+ SaveCallback callback) OVERRIDE;
+ virtual void LoadContent(const ArticleEntry& entry,
+ LoadCallback callback) OVERRIDE;
+
+ // Synchronously saves the content.
+ void InjectContent(const ArticleEntry& entry,
+ const DistilledArticleProto& proto);
+
+ private:
+ typedef base::hash_map<std::string, DistilledArticleProto> ContentMap;
+ ContentMap cache_;
+};
nyquist 2014/04/10 19:00:13 DISALLOW_COPY_AND_ASSIGN?
cjhopman 2014/04/11 22:37:21 Now disallowed in the base class.
+} // dom_distiller
+
+#endif // COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_CONTENT_CACHE_H_

Powered by Google App Engine
This is Rietveld 408576698